JiriOndrusek commented on code in PR #8877:
URL: https://github.com/apache/camel-quarkus/pull/8877#discussion_r3585034084
##########
integration-tests/quartz-clustered/src/test/java/org/apache/camel/quarkus/component/quartz/it/QuartzClusteredTest.java:
##########
@@ -101,7 +101,11 @@ public void clustering() throws IOException {
}
private void awaitStartup(QuarkusProcessExecutor quarkusProcessExecutor) {
- Awaitility.await().atMost(60, TimeUnit.SECONDS).pollDelay(1,
TimeUnit.SECONDS).until(() -> {
+ long timeout = ConfigProvider.getConfig()
+
.getOptionalValue("quartz.clustered.test.startup.timeout.seconds", Long.class)
Review Comment:
nitpick: Wouldn't be better to have this property in the
application.properties with some default value (60)? (it could be easier
recognizable then default in code here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
