davsclaus commented on PR #24677: URL: https://github.com/apache/camel/pull/24677#issuecomment-4967796638
_Claude Code on behalf of davsclaus_ Thanks for the thorough review @gnodet! Addressed in 74de2ad: **1. `loadClass(String, boolean)` ignores `resolve`** — Fixed. Now calls `resolveClass(c)` when `resolve=true`. **2. Re-added resources skip `CompilePreProcessor`** — Fixed. The hot-reload loop now runs the `CompilePreProcessor` chain on re-added resources, consistent with the initial compilation path. **3. `workDir` path no longer appends `/joor`** — Correct, this aligns both `JoorScriptingCompiler` and `JavaRoutesBuilderLoader` to use the same `workDir`. Old cached `.class` files under `workDir/joor/` will be orphaned but are harmless since it's a transient dev-mode cache. **5. `compiledClassNames` thread safety** — Fixed. Switched from `LinkedHashSet` to `ConcurrentHashMap.newKeySet()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
