davsclaus commented on PR #24669: URL: https://github.com/apache/camel/pull/24669#issuecomment-4962423642
Addressed all review feedback: 1. **Unit tests added** — three new tests in `AiPanelTest`: `functionKeysPassThroughToGlobalHandlers`, `f8ClosesPanel`, and `functionKeysPassThroughWhileThinking`. These pin the F-key dispatch contract. 2. **F8 exclusion commented** — `isFunctionKey` now has a comment: `// F8 intentionally excluded — it closes the panel and is handled above` 3. **F-keys during thinking: intentional** — Yes, this behavior change is intended. F-keys (F2 actions, F3 switch, F6 shell, etc.) should remain accessible while the AI is processing a request. The user can open the actions menu or switch integrations without cancelling the running AI query. Ctrl+C/Esc still cancel the AI request. 4. **PR title and description updated** — Now covers both the F-key dispatch fix and the ActionsPopup menu restructuring with separate sections. _Claude Code on behalf of davsclaus_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
