gnodet opened a new pull request, #24660: URL: https://github.com/apache/camel/pull/24660
## Summary Fix flaky JMS tests that use Spring XML configuration by addressing two root causes: queue name collisions between tests sharing a singleton Artemis broker, and race conditions where messages are sent before JMS consumers are fully subscribed. ### Changes - **Queue name isolation**: Renamed hardcoded generic queue names (`foo`, `bar`) to class-scoped names (e.g., `JmsSpringLoadBalanceFailOver.foo`) in `JmsSpringLoadBalanceFailOverIT.xml` to prevent cross-test contamination via the shared broker - **Route IDs for readiness**: Added explicit route IDs to Spring XML routes and Java route builders so `JmsTestHelper.waitForJmsConsumerRoutes()` can target them - **Readiness checks**: Added `JmsTestHelper.waitForJmsConsumerRoutes()` calls before sending messages to ensure JMS consumers are fully subscribed to the broker - **Timed assertions**: Replaced bare `MockEndpoint.assertIsSatisfied()` calls with `MockEndpoint.assertIsSatisfied(context, 30, TimeUnit.SECONDS)` for deterministic timeouts - **Queue name fix**: Corrected queue name mismatch in `RouteIdTransactedIT` (was using old class name `RouteIdTransactedTest`) ### Affected tests (7 test classes, 13 test methods) | Test Class | Fix Applied | |---|---| | `JmsSpringLoadBalanceFailOverJMSIT` | Queue isolation + readiness check | | `RouteIdTransactedIT` | Queue name fix + readiness check | | `JmsRouteUsingSpringIT` | Route IDs + readiness + timed assertions (via `JmsRouteTest`) | | `JmsRouteUsingSpringAndJmsNameIT` | Route IDs + readiness + timed assertions (via `JmsRouteTest`) | | `JmsRouteUsingSpringJMSTemplateIT` | Route IDs + readiness + timed assertions (via `JmsRouteTest`) | | `JmsRouteUsingSpringWithAutoWireIT` | Route IDs + readiness + timed assertions (via `JmsRouteTest`) | All 13 test methods pass locally. _Claude Code on behalf of gnodet_ Co-Authored-By: Claude Opus 4.6 <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
