jamesnetherton commented on code in PR #8787:
URL: https://github.com/apache/camel-quarkus/pull/8787#discussion_r3461859316
##########
integration-test-groups/aws2/aws-cloudtrail/pom.xml:
##########
@@ -25,26 +25,31 @@
<groupId>org.apache.camel.quarkus</groupId>
<artifactId>camel-quarkus-build-parent-it</artifactId>
<version>3.37.0-SNAPSHOT</version>
- <relativePath>../../poms/build-parent-it/pom.xml</relativePath>
+ <relativePath>../../../poms/build-parent-it/pom.xml</relativePath>
</parent>
- <artifactId>camel-quarkus-integration-test-github2</artifactId>
- <name>Camel Quarkus :: Integration Tests :: GitHub2</name>
- <description>Integration tests for Camel Quarkus GitHub2
extension</description>
+ <artifactId>camel-quarkus-integration-test-aws-cloudtrail</artifactId>
+ <name>Camel Quarkus :: Integration Tests :: AWS Cloudtrail</name>
+ <description>Integration tests for Camel Quarkus AWS Cloudtrail
extension</description>
<dependencies>
<dependency>
<groupId>org.apache.camel.quarkus</groupId>
- <artifactId>camel-quarkus-github2</artifactId>
+ <artifactId>camel-quarkus-aws-cloudtrail</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
- <artifactId>quarkus-resteasy</artifactId>
+ <artifactId>quarkus-resteasy-jackson</artifactId>
</dependency>
<dependency>
- <groupId>org.apache.camel.quarkus</groupId>
- <artifactId>camel-quarkus-integration-wiremock-support</artifactId>
- <scope>test</scope>
+ <groupId>software.amazon.awssdk</groupId>
+ <artifactId>cloudtrail</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>commons-logging</groupId>
+ <artifactId>commons-logging</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need this? The same exclusion is already applied to
`camel-aws-cloudtrail`.
##########
integration-test-groups/aws2/aws-cloudtrail/pom.xml:
##########
@@ -58,6 +63,16 @@
<artifactId>rest-assured</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-integration-wiremock-support</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
I guess WireMock is used because LocalStack does not support Cloudtrail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
