ammachado opened a new pull request, #24121:
URL: https://github.com/apache/camel/pull/24121
# Description
When `SimpleExpressionParser` and `SimplePredicateParser` substitute
init-block variable names into the expression string, a shorter key that is a
prefix of a longer one (e.g. `$n` and `$name`) can match first and corrupt the
substitution: `$name` becomes `${variable.n}ame`.
The fix sorts the keys by descending length before iterating, so longer
(more specific) keys are always replaced first.
A new `SimpleInitBlockOverlappingKeysTest` demonstrates the bug: both
fixtures declare the short key first (so insertion order is shortest-first, the
corrupting order), and the tests fail without the sort and pass with it.
Discovered during the work on CAMEL-22894 (simple language parser hardening).
_Claude Code on behalf of Adriano Machado_
# Target
- [x] I checked that the commit is targeting the correct branch (Camel 4
uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for
the change (usually before you start working on it).
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful
subject line and body.
- [x] I have run `mvn clean install -DskipTests` locally from root folder
and I have committed all auto-generated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
