squakez commented on code in PR #6687: URL: https://github.com/apache/camel-k/pull/6687#discussion_r3435779839
########## docs/modules/traits/pages/affinity.adoc: ########## @@ -85,3 +85,5 @@ $ kamel run -t affinity.pod-anti-affinity-labels="camel.apache.org/integration" ---- More information can be found in the official Kubernetes documentation about https://kubernetes.io/docs/concepts/configuration/assign-pod-node/[Assigning Pods to Nodes]. + +NOTE: Operators can restrict which label keys CR authors are permitted to use in `affinity.nodeAffinityLabels` by setting the `AFFINITY_NODE_LABELS_ALLOWED_KEYS` environment variable on the operator deployment to a comma-separated list of allowed keys (e.g. `kubernetes.io/hostname,topology.kubernetes.io/zone`). Expressions whose key is not in the list are dropped and an info message is logged. When the variable is unset or empty, all keys are accepted (default behavior). See xref:installation:builds.adoc#env-var-config[build environment variables] for details. Review Comment: ```suggestion NOTE: Operators can restrict which label keys CR authors are permitted to use in `affinity.nodeAffinityLabels` by setting the `AFFINITY_NODE_LABELS_ALLOWED_KEYS` environment variable on the operator deployment to a comma-separated list of allowed keys (e.g. `kubernetes.io/hostname,topology.kubernetes.io/zone`). Expressions whose key is not in the list are dropped and an info message is logged. When the variable is unset or empty, all keys are accepted (default behavior). See build environment variables documentation for details. ``` ########## docs/modules/traits/pages/affinity.adoc: ########## @@ -85,3 +85,5 @@ $ kamel run -t affinity.pod-anti-affinity-labels="camel.apache.org/integration" ---- More information can be found in the official Kubernetes documentation about https://kubernetes.io/docs/concepts/configuration/assign-pod-node/[Assigning Pods to Nodes]. + +NOTE: Operators can restrict which label keys CR authors are permitted to use in `affinity.nodeAffinityLabels` by setting the `AFFINITY_NODE_LABELS_ALLOWED_KEYS` environment variable on the operator deployment to a comma-separated list of allowed keys (e.g. `kubernetes.io/hostname,topology.kubernetes.io/zone`). Expressions whose key is not in the list are dropped and an info message is logged. When the variable is unset or empty, all keys are accepted (default behavior). See xref:installation:builds.adoc#env-var-config[build environment variables] for details. Review Comment: the xref link is wrong. No need however to provide hyperlink -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
