davsclaus commented on PR #23773: URL: https://github.com/apache/camel/pull/23773#issuecomment-4624950016
> > Clean, well-scoped enhancement. All 8 new options follow the existing `http2Enabled` pattern exactly — nullable fields with null checks before `setServerOption()`. Documentation table covers all host options (existing + new) with a properties configuration example. Test covers `maxEntitySize` for both within-limit and exceeding-limit cases. > > Minor: only `maxEntitySize` has a test — the other 7 options follow the identical pattern so the risk is low, but a test for one more option (e.g., `maxHeaders`) would strengthen confidence. > > This review does not replace specialized AI review tools (CodeRabbit, Sourcery) or static analysis (SonarCloud). > > _This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying._ > > Yeah, I tested only one configuration on puspose, anyway, they are just set on an object, nothing fancy Yeah we dont escape the eyes from the AI ;) LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
