Croway commented on code in PR #23500: URL: https://github.com/apache/camel/pull/23500#discussion_r3298776185
########## components/camel-micrometer-observability/src/main/docs/micrometer-observability.adoc: ########## @@ -31,7 +31,8 @@ The configuration properties for the component are: |`enabled`| false | Turn the tracing on/off. |`traceProcessors`| false | Trace inner custom processors (i.e., any `process` configured in the route). |`disableCoreProcessors`| false | Disable any inner core processors (any core DSL processor provided in the route, for example `bean`, `log`, ...). -|`excludePatterns` | | Sets exclude pattern that will disable tracing for those spans that matches the pattern. The variable is a comma separated values of filters to execute (eg, `log*,direct*,setBody*`, ...) +| `excludePatterns` | | A comma-separated list of patterns (e.g., `log*,direct*,setBody*`) to exclude from tracing. Spans matching these patterns will be disabled. If nothing is specified, no processors are excluded by default. +| `includePatterns` | | A comma-separated list of patterns (e.g., `log*,direct*,setBody*`) to explicitly include in a trace. Spans matching these patterns will be enabled. If nothing is specified, all processors are included by default. Review Comment: what happen when excludePatterns and includePatterns are used together? exclude should win, do you think it is worth documenting this behaviour? @squakez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
