apupier commented on code in PR #478:
URL:
https://github.com/apache/camel-quarkus-examples/pull/478#discussion_r2912327394
##########
amqp/README.adoc:
##########
@@ -10,17 +10,17 @@ and other general information.
== Prerequisites:
-In order to send or receive message from Artemis Broker you need to start a
service.
-You can either run the container or start downloaded binary.
+In order to send or receive messages to / from the Artemis Broker, you need to
start a service.
+You can either run Artemis in a container or downloaded the Artemis binary
distrubtion.
Review Comment:
`or downloaded` --> `or download`?
##########
amqp/README.adoc:
##########
@@ -10,17 +10,17 @@ and other general information.
== Prerequisites:
-In order to send or receive message from Artemis Broker you need to start a
service.
-You can either run the container or start downloaded binary.
+In order to send or receive messages to / from the Artemis Broker, you need to
start a service.
+You can either run Artemis in a container or downloaded the Artemis binary
distrubtion.
Review Comment:
distrubtion --> distribution
##########
fhir/README.adoc:
##########
@@ -17,12 +17,12 @@ To run the application in development, from the runnable
JAR or as a native appl
docker run -ti -e hapi.fhir.fhir_version=R4 \
-e hapi.fhir.allow_multiple_delete=true -e \
-e hapi.fhir.reuse_cached_search_results_millis=-1 \
- -p 8080:8080 mirror.gcr.io/hapiproject/hapi:v7.4.0
+ -p 8080:8080 mirror.gcr.io/hapiproject/hapi:v8.2.0-2
Review Comment:
the 8.6.0-1 is used for Camel 4.18
https://github.com/apache/camel/blob/dd22f752e240bd1343af15c775ef02d754f6df38/test-infra/camel-test-infra-fhir/src/main/resources/org/apache/camel/test/infra/fhir/services/container.properties#L17
##########
message-bridge/README.adoc:
##########
@@ -194,7 +194,7 @@ oc patch service/activemq-artemis-broker -p
'{"spec":{"ports":[{"name":"61616-tc
----
----
-oc new-app icr.io/ibm-messaging/mq:9.3.2.1-r1 -e MQ_QMGR_NAME=QM1 -e
LICENSE=accept -e MQ_APP_PASSWORD=passw0rd
+oc new-app icr.io/ibm-messaging/mq:9.4.5.0-r1 -e MQ_QMGR_NAME=QM1 -e
LICENSE=accept -e MQ_APP_PASSWORD=passw0rd
Review Comment:
is ti tested locally? the upgrade was not done on Camel core side
https://github.com/apache/camel/pull/21892
##########
data-extract-langchain4j/src/test/java/org/acme/extraction/OllamaTestResource.java:
##########
@@ -36,7 +36,7 @@ public class OllamaTestResource implements
QuarkusTestResourceLifecycleManager {
private static final Logger LOG =
LoggerFactory.getLogger(OllamaTestResource.class);
- private static final String OLLAMA_IMAGE = "ollama/ollama:0.14.1";
+ private static final String OLLAMA_IMAGE = "ollama/ollama:0.17.7";
Review Comment:
have you tested with this version? On Camel core, the upgrade of the image
to
0.17.7 has not been done yet due to failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
