apupier commented on code in PR #8142: URL: https://github.com/apache/camel-quarkus/pull/8142#discussion_r2690613740
########## integration-tests/master-file/src/test/java/org/apache/camel/quarkus/component/master/it/MasterFileTestResource.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.quarkus.component.master.it; + +import java.io.IOException; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.Map; + +import io.quarkus.test.common.QuarkusTestResourceLifecycleManager; +import org.apache.commons.io.FileUtils; +import org.jboss.logging.Logger; + +public class MasterFileTestResource implements QuarkusTestResourceLifecycleManager { + private static final Logger LOG = Logger.getLogger(MasterFileTestResource.class); + + @Override + public Map<String, String> start() { + // We need to clean up cluster data early as possible, before the app under test is started to avoid potential races on lock files with Windows Review Comment: no strong opinion. I usually prefer to clean the file created by the test to avoid interaction with others and comment/uncomment code if needed for investigation. In my experience, I spent more time investigating why a test was flaky due to interaction between different one than looking to output of a test which was already written. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
