squakez commented on code in PR #20375:
URL: https://github.com/apache/camel/pull/20375#discussion_r2618473867
##########
core/camel-util/src/main/java/org/apache/camel/util/AnnotationHelper.java:
##########
@@ -80,7 +80,7 @@ public static boolean hasAnnotation(
if (checkMetaAnnotations) {
for (Annotation a : elem.getAnnotations()) {
for (Annotation meta : a.annotationType().getAnnotations()) {
- if
(meta.annotationType().getName().equals(annotationType.getName())) {
+ if (meta.annotationType() == annotationType) {
Review Comment:
Okey. This is quite an important consideration. I completely overlooked that
and did not consider the differences that an OSGI environment could involve.
I'll revert this change here and review the other recent changes to make sure
that it don't break the original design intents. That's exactly the reason why
I advocate for adding clarification comment notes in those parts of the code
that can be misinterpreted by any new maintainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
