This is an automated email from the ASF dual-hosted git repository.
pcongiusti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push:
new e002e8e5451c chore: comment usage of Random numbers
e002e8e5451c is described below
commit e002e8e5451cb3c1a1c6a0b73dd1f2fc2512204c
Author: Pasquale Congiusti <[email protected]>
AuthorDate: Fri Dec 5 12:40:37 2025 +0100
chore: comment usage of Random numbers
Also fixing minor compilation warnings found during the task
---
.../apache/camel/component/jms/reply/QueueReplyManager.java | 6 ++----
.../java/org/apache/camel/component/jms/JmsBindingTest.java | 11 ++++++-----
.../camel/component/jms/JmsDefaultTaskExecutorTypeTest.java | 8 +++++---
.../camel/component/jms/JmsInOnlyDisableTimeToLiveTest.java | 4 ----
.../apache/camel/component/jms/JmsPriorityConsumerTest.java | 3 ---
.../jms/JmsRouteWithCustomListenerContainerTest.java | 2 ++
.../component/jms/issues/JmsConcurrentConsumerInOnlyTest.java | 2 +-
.../cluster/lock/KubernetesLeadershipController.java | 2 +-
.../camel/component/telegram/TelegramWebhookProcessor.java | 2 +-
.../component/telegram/service/TelegramBodyPublisher.java | 2 +-
.../main/java/org/apache/camel/test/AvailablePortFinder.java | 2 +-
.../java/org/apache/camel/test/junit5/ThrottlingExecutor.java | 1 -
.../junit5/patterns/CreateCamelContextPerTestFalseTest.java | 1 -
.../apache/camel/test/junit5/patterns/DebugJUnit5Test.java | 2 --
.../test/junit5/patterns/DebugNoLazyTypeConverterTest.java | 2 --
.../java/org/apache/camel/test/junit5/patterns/DebugTest.java | 2 --
.../main/java/org/apache/camel/test/AvailablePortFinder.java | 2 +-
.../camel/component/whatsapp/WhatsAppWebhookProcessor.java | 2 +-
.../whatsapp/service/WhatsAppServiceRestAPIAdapter.java | 2 +-
.../org/apache/camel/impl/cloud/RandomServiceChooser.java | 2 +-
.../camel/processor/aggregate/OptimisticLockRetryPolicy.java | 2 +-
.../camel/processor/loadbalancer/RandomLoadBalancer.java | 2 +-
.../processor/loadbalancer/WeightedRandomLoadBalancer.java | 2 +-
.../main/java/org/apache/camel/support/DefaultEndpoint.java | 1 -
.../main/java/org/apache/camel/support/DefaultRegistry.java | 1 -
.../java/org/apache/camel/support/DefaultUuidGenerator.java | 2 +-
.../main/java/org/apache/camel/support/EndpointHelper.java | 2 +-
.../src/main/java/org/apache/camel/support/ObjectHelper.java | 4 ++--
.../java/org/apache/camel/support/ScheduledPollConsumer.java | 3 +--
.../java/org/apache/camel/support/ShortUuidGenerator.java | 2 +-
.../apache/camel/support/SingleInputTypedLanguageSupport.java | 1 -
.../java/org/apache/camel/support/SynchronizationAdapter.java | 2 +-
.../main/java/org/apache/camel/support/cache/ServicePool.java | 1 -
.../camel/support/component/EndpointUriFactorySupport.java | 3 +--
.../org/apache/camel/support/processor/DelegateProcessor.java | 2 +-
.../org/apache/camel/support/processor/ThroughputLogger.java | 3 +--
.../support/scan/DefaultPackageScanResourceResolver.java | 3 +--
.../java/org/apache/camel/dsl/jbang/core/commands/Run.java | 2 +-
.../artemis/services/AbstractArtemisEmbeddedService.java | 2 +-
39 files changed, 40 insertions(+), 60 deletions(-)
diff --git
a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java
b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java
index 1c37c210ebc7..745ea41773d6 100644
---
a/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java
+++
b/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/QueueReplyManager.java
@@ -148,8 +148,7 @@ public class QueueReplyManager extends ReplyManagerSupport {
String replyToSelectorName =
endpoint.getReplyToDestinationSelectorName();
if (replyToSelectorName != null) {
// create a random selector value we will use for the reply
queue
- // NOSONAR
- replyToSelectorValue = "ID:" + new BigInteger(24 * 8, new
Random()).toString(16);
+ replyToSelectorValue = "ID:" + new BigInteger(24 * 8, new
Random()).toString(16); // NOSONAR
String fixedMessageSelector = replyToSelectorName + "='" +
replyToSelectorValue + "'";
answer = new
SharedQueueSimpleMessageListenerContainer(endpoint, fixedMessageSelector);
log.debug("Using shared queue: {} with fixed message selector
[{}] as reply listener: {}",
@@ -231,8 +230,7 @@ public class QueueReplyManager extends ReplyManagerSupport {
String replyToSelectorName =
endpoint.getReplyToDestinationSelectorName();
if (replyToSelectorName != null) {
// create a random selector value we will use for the reply
queue
- // NOSONAR
- replyToSelectorValue = "ID:" + new BigInteger(24 * 8, new
Random()).toString(16);
+ replyToSelectorValue = "ID:" + new BigInteger(24 * 8, new
Random()).toString(16); // NOSONAR
String fixedMessageSelector = replyToSelectorName + "='" +
replyToSelectorValue + "'";
answer = new SharedQueueMessageListenerContainer(endpoint,
fixedMessageSelector);
log.debug("Using shared queue: {} with fixed message selector
[{}] as reply listener: {}",
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsBindingTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsBindingTest.java
index 6794c45c3476..bee2e5944390 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsBindingTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsBindingTest.java
@@ -66,11 +66,12 @@ public class JmsBindingTest {
ActiveMQTextMessage message = mock(ActiveMQTextMessage.class);
message.setText("test");
- DefaultCamelContext camelContext = new DefaultCamelContext();
- Exchange exchange =
camelContext.getEndpoint("jms:queue:foo").createExchange();
- exchange.getIn().setBody("test");
- exchange.getIn().setHeader("JMSCorrelationID", null);
- assertDoesNotThrow(() ->
testBindingWithoutEndpoint.appendJmsProperties(message, exchange));
+ try (DefaultCamelContext camelContext = new DefaultCamelContext()) {
+ Exchange exchange =
camelContext.getEndpoint("jms:queue:foo").createExchange();
+ exchange.getIn().setBody("test");
+ exchange.getIn().setHeader("JMSCorrelationID", null);
+ assertDoesNotThrow(() ->
testBindingWithoutEndpoint.appendJmsProperties(message, exchange));
+ }
}
@Test
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java
index b104ccd84814..c1966a560cb7 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsDefaultTaskExecutorTypeTest.java
@@ -180,16 +180,18 @@ class JmsDefaultTaskExecutorTypeTest extends
CamelTestSupport {
public void configure() {
from("activemq:queue:foo.JmsDefaultTaskExecutorTypeTest.simpleAsync?defaultTaskExecutorType=SimpleAsync")
.routeId("simpleAsync")
- .noAutoStartup()
+ .autoStartup(false)
.to("mock:result.simpleAsync")
.setBody(constant("Reply"));
from("activemq:queue:foo.JmsDefaultTaskExecutorTypeTest.threadPool?defaultTaskExecutorType=ThreadPool")
- .routeId("threadPool").noAutoStartup()
+ .routeId("threadPool")
+ .autoStartup(false)
.to("mock:result.threadPool")
.setBody(constant("Reply"));
-
from("activemq:queue:foo.JmsDefaultTaskExecutorTypeTest.default").routeId("default").noAutoStartup()
+
from("activemq:queue:foo.JmsDefaultTaskExecutorTypeTest.default").routeId("default")
+ .autoStartup(false)
.to("mock:result.default")
.setBody(constant("Reply"));
}
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyDisableTimeToLiveTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyDisableTimeToLiveTest.java
index 0cae1c019371..640f04b5279f 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyDisableTimeToLiveTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsInOnlyDisableTimeToLiveTest.java
@@ -31,13 +31,9 @@ import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Order;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
public class JmsInOnlyDisableTimeToLiveTest extends AbstractJMSTest {
- private static final Logger LOG =
LoggerFactory.getLogger(JmsInOnlyDisableTimeToLiveTest.class);
-
@Order(2)
@RegisterExtension
public static CamelContextExtension camelContextExtension = new
TransientCamelContextExtension();
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsPriorityConsumerTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsPriorityConsumerTest.java
index 76732dfc9d74..6dd79d612b0e 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsPriorityConsumerTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsPriorityConsumerTest.java
@@ -20,7 +20,6 @@ import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.TimeUnit;
-import org.apache.camel.CamelContext;
import org.apache.camel.ProducerTemplate;
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.component.mock.MockEndpoint;
@@ -41,7 +40,6 @@ public class JmsPriorityConsumerTest extends AbstractJMSTest {
public static CamelContextExtension camelContextExtension = new
DefaultCamelContextExtension();
protected ProducerTemplate template;
- private CamelContext context;
@Override
protected String getComponentName() {
@@ -98,7 +96,6 @@ public class JmsPriorityConsumerTest extends AbstractJMSTest {
@BeforeEach
void setUpRequirements() {
- context = camelContextExtension.getContext();
template = camelContextExtension.getProducerTemplate();
}
}
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java
index 8888976ae185..4eae1e77a62a 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteWithCustomListenerContainerTest.java
@@ -59,9 +59,11 @@ public class JmsRouteWithCustomListenerContainerTest extends
AbstractJMSTest {
@Test
public void testSendOrder() throws Exception {
MockEndpoint inbox = getMockEndpoint("mock:inbox");
+ inbox.reset();
inbox.expectedBodiesReceived("Camel in Action");
MockEndpoint order = getMockEndpoint("mock:topic");
+ order.reset();
order.expectedBodiesReceived("Camel in Action");
Object out =
template.requestBody("activemq:queue:JmsRouteWithCustomListenerContainerTest",
"Camel in Action");
diff --git
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsConcurrentConsumerInOnlyTest.java
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsConcurrentConsumerInOnlyTest.java
index 8e4ece593de8..85260d3bf8f2 100644
---
a/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsConcurrentConsumerInOnlyTest.java
+++
b/components/camel-jms/src/test/java/org/apache/camel/component/jms/issues/JmsConcurrentConsumerInOnlyTest.java
@@ -69,7 +69,7 @@ public class JmsConcurrentConsumerInOnlyTest extends
CamelTestSupport {
return new RouteBuilder() {
public void configure() {
from("activemq:JmsConcurrentConsumerInOnlyTest?concurrentConsumers=2&maxConcurrentConsumers=5").routeId("foo")
- .noAutoStartup()
+ .autoStartup(false)
.log("${threadName} got ${body}")
.delay(simple("${random(0,10)}"))
.to("mock:foo");
diff --git
a/components/camel-kubernetes/src/main/java/org/apache/camel/component/kubernetes/cluster/lock/KubernetesLeadershipController.java
b/components/camel-kubernetes/src/main/java/org/apache/camel/component/kubernetes/cluster/lock/KubernetesLeadershipController.java
index dd0025be5686..00bfdce5e23a 100644
---
a/components/camel-kubernetes/src/main/java/org/apache/camel/component/kubernetes/cluster/lock/KubernetesLeadershipController.java
+++
b/components/camel-kubernetes/src/main/java/org/apache/camel/component/kubernetes/cluster/lock/KubernetesLeadershipController.java
@@ -489,6 +489,6 @@ public class KubernetesLeadershipController implements
Service {
}
private long jitter(long num, double factor) {
- return (long) (num * (1 + Math.random() * (factor - 1)));
+ return (long) (num * (1 + Math.random() * (factor - 1))); // NOSONAR
}
}
diff --git
a/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/TelegramWebhookProcessor.java
b/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/TelegramWebhookProcessor.java
index 550172ec126c..3479555b58b2 100644
---
a/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/TelegramWebhookProcessor.java
+++
b/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/TelegramWebhookProcessor.java
@@ -29,7 +29,7 @@ import org.apache.camel.support.AsyncProcessorSupport;
import static
org.apache.camel.component.telegram.util.TelegramMessageHelper.populateExchange;
-public class TelegramWebhookProcessor extends AsyncProcessorSupport implements
AsyncProcessor {
+public class TelegramWebhookProcessor extends AsyncProcessorSupport {
private static final ObjectMapper MAPPER = new ObjectMapper();
diff --git
a/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/service/TelegramBodyPublisher.java
b/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/service/TelegramBodyPublisher.java
index 9590bbcd0b51..f7414ba4f3ec 100644
---
a/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/service/TelegramBodyPublisher.java
+++
b/components/camel-telegram/src/main/java/org/apache/camel/component/telegram/service/TelegramBodyPublisher.java
@@ -34,7 +34,7 @@ public class TelegramBodyPublisher {
private static final Logger LOG =
LoggerFactory.getLogger(TelegramBodyPublisher.class);
private final Set<TelegramBodyPart> bodyParts = new LinkedHashSet<>();
- private final String boundary = RandomStringUtils.randomAlphanumeric(12);
+ private final String boundary =
RandomStringUtils.secure().nextAlphanumeric(12);
private final int bufferSize;
public TelegramBodyPublisher(int bufferSize) {
diff --git
a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/AvailablePortFinder.java
b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/AvailablePortFinder.java
index 459a1155e2c7..d66dc0894c3a 100644
---
a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/AvailablePortFinder.java
+++
b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/AvailablePortFinder.java
@@ -139,7 +139,7 @@ public final class AvailablePortFinder {
* @return the available port
*/
public static int getNextRandomAvailable() {
- Random random = new Random();
+ Random random = new Random(); // NOSONAR
int fromPort = random.nextInt(10000, 65500);
int toPort = random.nextInt(fromPort, 65500);
try (Port port = INSTANCE.findPort(fromPort, toPort)) {
diff --git
a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/ThrottlingExecutor.java
b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/ThrottlingExecutor.java
index 12ab40ecf295..ae23ae750ea3 100644
---
a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/ThrottlingExecutor.java
+++
b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/ThrottlingExecutor.java
@@ -26,7 +26,6 @@ public final class ThrottlingExecutor {
private final List<IntConsumer> beforeTasks = new ArrayList<>();
private final List<IntConsumer> afterTasks = new ArrayList<>();
private int repetitions;
- private long beforeWait;
private long awaiting;
private TimeUnit timeUnit;
diff --git
a/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/CreateCamelContextPerTestFalseTest.java
b/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/CreateCamelContextPerTestFalseTest.java
index 149edb9b08be..46c05862bab6 100644
---
a/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/CreateCamelContextPerTestFalseTest.java
+++
b/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/CreateCamelContextPerTestFalseTest.java
@@ -59,7 +59,6 @@ public class CreateCamelContextPerTestFalseTest extends
CamelTestSupport {
protected void doPostTearDown() throws Exception {
LOG.info("doPostTearDown()");
POST_TEAR_DOWN.incrementAndGet();
- super.doPostTearDown();
}
@Test
diff --git
a/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugJUnit5Test.java
b/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugJUnit5Test.java
index 2237ba0109ed..bc62c1540828 100644
---
a/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugJUnit5Test.java
+++
b/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugJUnit5Test.java
@@ -29,8 +29,6 @@ public class DebugJUnit5Test extends CamelTestSupport {
@Override
public void doPreSetup() throws Exception {
- super.doPreSetup();
-
camelContextConfiguration()
.withBreakpoint(createBreakpoint());
}
diff --git
a/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugNoLazyTypeConverterTest.java
b/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugNoLazyTypeConverterTest.java
index 6ff409133d2f..d6f48c1ef116 100644
---
a/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugNoLazyTypeConverterTest.java
+++
b/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugNoLazyTypeConverterTest.java
@@ -29,8 +29,6 @@ public class DebugNoLazyTypeConverterTest extends
CamelTestSupport {
@Override
public void doPreSetup() throws Exception {
- super.doPreSetup();
-
camelContextConfiguration()
.withBreakpoint(createBreakpoint());
}
diff --git
a/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugTest.java
b/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugTest.java
index 80dc31bbc69f..697fd53accca 100644
---
a/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugTest.java
+++
b/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/DebugTest.java
@@ -29,8 +29,6 @@ public class DebugTest extends CamelTestSupport {
@Override
public void doPreSetup() throws Exception {
- super.doPreSetup();
-
camelContextConfiguration()
.withBreakpoint(createBreakpoint());
}
diff --git
a/components/camel-test/camel-test-junit6/src/main/java/org/apache/camel/test/AvailablePortFinder.java
b/components/camel-test/camel-test-junit6/src/main/java/org/apache/camel/test/AvailablePortFinder.java
index 459a1155e2c7..d66dc0894c3a 100644
---
a/components/camel-test/camel-test-junit6/src/main/java/org/apache/camel/test/AvailablePortFinder.java
+++
b/components/camel-test/camel-test-junit6/src/main/java/org/apache/camel/test/AvailablePortFinder.java
@@ -139,7 +139,7 @@ public final class AvailablePortFinder {
* @return the available port
*/
public static int getNextRandomAvailable() {
- Random random = new Random();
+ Random random = new Random(); // NOSONAR
int fromPort = random.nextInt(10000, 65500);
int toPort = random.nextInt(fromPort, 65500);
try (Port port = INSTANCE.findPort(fromPort, toPort)) {
diff --git
a/components/camel-whatsapp/src/main/java/org/apache/camel/component/whatsapp/WhatsAppWebhookProcessor.java
b/components/camel-whatsapp/src/main/java/org/apache/camel/component/whatsapp/WhatsAppWebhookProcessor.java
index 5dd76b893159..e9158ae9cd22 100644
---
a/components/camel-whatsapp/src/main/java/org/apache/camel/component/whatsapp/WhatsAppWebhookProcessor.java
+++
b/components/camel-whatsapp/src/main/java/org/apache/camel/component/whatsapp/WhatsAppWebhookProcessor.java
@@ -30,7 +30,7 @@ import org.apache.camel.support.AsyncProcessorSupport;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class WhatsAppWebhookProcessor extends AsyncProcessorSupport implements
AsyncProcessor {
+public class WhatsAppWebhookProcessor extends AsyncProcessorSupport {
private static final Logger LOG =
LoggerFactory.getLogger(WhatsAppWebhookProcessor.class);
private static final String MODE_QUERY_PARAM = "hub.mode";
diff --git
a/components/camel-whatsapp/src/main/java/org/apache/camel/component/whatsapp/service/WhatsAppServiceRestAPIAdapter.java
b/components/camel-whatsapp/src/main/java/org/apache/camel/component/whatsapp/service/WhatsAppServiceRestAPIAdapter.java
index 20bcb62d1b80..0b4c73abecd9 100644
---
a/components/camel-whatsapp/src/main/java/org/apache/camel/component/whatsapp/service/WhatsAppServiceRestAPIAdapter.java
+++
b/components/camel-whatsapp/src/main/java/org/apache/camel/component/whatsapp/service/WhatsAppServiceRestAPIAdapter.java
@@ -124,7 +124,7 @@ public class WhatsAppServiceRestAPIAdapter implements
WhatsAppService {
formData.put("messaging_product", "whatsapp");
formData.put("file", message.getUploadMedia());
- String boundary = new BigInteger(256, new Random()).toString();
+ String boundary = new BigInteger(256, new Random()).toString(); //
NOSONAR
try {
builder.POST(ofStreamPart(formData, boundary));
} catch (IOException e) {
diff --git
a/core/camel-cloud/src/main/java/org/apache/camel/impl/cloud/RandomServiceChooser.java
b/core/camel-cloud/src/main/java/org/apache/camel/impl/cloud/RandomServiceChooser.java
index 72bf36213088..2dac4f5fa4bf 100644
---
a/core/camel-cloud/src/main/java/org/apache/camel/impl/cloud/RandomServiceChooser.java
+++
b/core/camel-cloud/src/main/java/org/apache/camel/impl/cloud/RandomServiceChooser.java
@@ -39,7 +39,7 @@ public class RandomServiceChooser implements ServiceChooser {
if (size == 1) {
return definitions.get(0);
} else {
- return definitions.get(ThreadLocalRandom.current().nextInt(size));
+ return definitions.get(ThreadLocalRandom.current().nextInt(size));
// NOSONAR
}
}
diff --git
a/core/camel-core-processor/src/main/java/org/apache/camel/processor/aggregate/OptimisticLockRetryPolicy.java
b/core/camel-core-processor/src/main/java/org/apache/camel/processor/aggregate/OptimisticLockRetryPolicy.java
index b71c95bdabdf..4f1f8b95c381 100644
---
a/core/camel-core-processor/src/main/java/org/apache/camel/processor/aggregate/OptimisticLockRetryPolicy.java
+++
b/core/camel-core-processor/src/main/java/org/apache/camel/processor/aggregate/OptimisticLockRetryPolicy.java
@@ -70,7 +70,7 @@ public class OptimisticLockRetryPolicy {
sleepFor = exponentialBackOff
? (retryDelay << retryCounter)
: (randomBackOff
- ? ThreadLocalRandom.current()
+ ? ThreadLocalRandom.current() // NOSONAR
.nextInt((int) (maximumRetryDelay > 0 ?
maximumRetryDelay : DEFAULT_MAXIMUM_RETRY_DELAY))
: retryDelay);
if (maximumRetryDelay > 0 && sleepFor > maximumRetryDelay) {
diff --git
a/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/RandomLoadBalancer.java
b/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/RandomLoadBalancer.java
index f581b5ed79fd..5901d3c520e3 100644
---
a/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/RandomLoadBalancer.java
+++
b/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/RandomLoadBalancer.java
@@ -39,7 +39,7 @@ public class RandomLoadBalancer extends QueueLoadBalancer {
}
// pick a random
- index = ThreadLocalRandom.current().nextInt(size);
+ index = ThreadLocalRandom.current().nextInt(size); // NOSONAR
return processors[index];
}
diff --git
a/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/WeightedRandomLoadBalancer.java
b/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/WeightedRandomLoadBalancer.java
index c125043570f4..5692850c35f4 100644
---
a/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/WeightedRandomLoadBalancer.java
+++
b/core/camel-core-processor/src/main/java/org/apache/camel/processor/loadbalancer/WeightedRandomLoadBalancer.java
@@ -32,7 +32,7 @@ public class WeightedRandomLoadBalancer extends
WeightedLoadBalancer {
protected AsyncProcessor chooseProcessor(AsyncProcessor[] processors,
Exchange exchange) {
lock.lock();
try {
- int randomWeight =
ThreadLocalRandom.current().nextInt(runtimeRatioSum);
+ int randomWeight =
ThreadLocalRandom.current().nextInt(runtimeRatioSum); // NOSONAR
int choiceWeight = 0;
int index = 0;
while (true) {
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/DefaultEndpoint.java
b/core/camel-support/src/main/java/org/apache/camel/support/DefaultEndpoint.java
index 2ff0c296aa01..4058eb13aaba 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/DefaultEndpoint.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/DefaultEndpoint.java
@@ -17,7 +17,6 @@
package org.apache.camel.support;
import java.util.Map;
-import java.util.Set;
import org.apache.camel.AsyncProducer;
import org.apache.camel.CamelContext;
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/DefaultRegistry.java
b/core/camel-support/src/main/java/org/apache/camel/support/DefaultRegistry.java
index 2e4c753ddef7..fb9b3f697129 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/DefaultRegistry.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/DefaultRegistry.java
@@ -43,7 +43,6 @@ import org.apache.camel.util.function.Suppliers;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import static org.apache.camel.util.ObjectHelper.isEmpty;
import static org.apache.camel.util.ObjectHelper.isNotEmpty;
/**
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/DefaultUuidGenerator.java
b/core/camel-support/src/main/java/org/apache/camel/support/DefaultUuidGenerator.java
index 068d7af64877..1e685f6e6c16 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/DefaultUuidGenerator.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/DefaultUuidGenerator.java
@@ -29,7 +29,7 @@ public class DefaultUuidGenerator implements UuidGenerator {
private static final char[] HEX_ARRAY = "0123456789ABCDEF".toCharArray();
private final char[] seed
- = (longToHex(new char[0],
ThreadLocalRandom.current().nextLong()).substring(1) + "-").toCharArray();
+ = (longToHex(new char[0],
ThreadLocalRandom.current().nextLong()).substring(1) + "-").toCharArray(); //
NOSONAR
private final AtomicLong index = new AtomicLong();
@Override
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/EndpointHelper.java
b/core/camel-support/src/main/java/org/apache/camel/support/EndpointHelper.java
index 65e60755b66b..ba45fa75279a 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/EndpointHelper.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/EndpointHelper.java
@@ -458,7 +458,7 @@ public final class EndpointHelper {
* @return list of lookup results, will always
return a list.
* @throws IllegalArgumentException if any referenced object was not found
in registry.
*/
- @SuppressWarnings({ "unchecked", "rawtypes" })
+ @SuppressWarnings("unchecked")
public static <T> List<T> resolveReferenceListParameter(CamelContext
context, String value, Class<T> elementType) {
if (value == null) {
return new ArrayList<>();
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java
b/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java
index 91b49af2d7ca..85dab79a5b39 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java
@@ -258,7 +258,7 @@ public final class ObjectHelper {
* and right values. This allows you test for ordering for example with a
String and Integer type as Camel will be
* able to coerce the types.
*/
- @SuppressWarnings({ "unchecked", "rawtypes" })
+ @SuppressWarnings("unchecked")
public static int typeCoerceCompare(TypeConverter converter, Object
leftValue, Object rightValue) {
// optimize for common combinations of comparing numbers
@@ -567,7 +567,7 @@ public final class ObjectHelper {
* @param b the second object
* @param ignoreCase ignore case for string comparison
*/
- @SuppressWarnings({ "unchecked", "rawtypes" })
+ @SuppressWarnings("unchecked")
public static int compare(Object a, Object b, boolean ignoreCase) {
if (a == b) {
return 0;
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/ScheduledPollConsumer.java
b/core/camel-support/src/main/java/org/apache/camel/support/ScheduledPollConsumer.java
index 14a634b5a44d..c9cfdcb1258a 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/ScheduledPollConsumer.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/ScheduledPollConsumer.java
@@ -33,7 +33,6 @@ import org.apache.camel.PollingConsumerPollingStrategy;
import org.apache.camel.Processor;
import org.apache.camel.Suspendable;
import org.apache.camel.health.HealthCheck;
-import org.apache.camel.health.HealthCheckAware;
import org.apache.camel.spi.HttpResponseAware;
import org.apache.camel.spi.PollingConsumerPollStrategy;
import org.apache.camel.spi.ScheduledPollConsumerScheduler;
@@ -47,7 +46,7 @@ import org.slf4j.LoggerFactory;
* A useful base class for any consumer which is polling based
*/
public abstract class ScheduledPollConsumer extends DefaultConsumer
- implements Runnable, Suspendable, PollingConsumerPollingStrategy,
HealthCheckAware {
+ implements Runnable, Suspendable, PollingConsumerPollingStrategy {
private static final Logger LOG =
LoggerFactory.getLogger(ScheduledPollConsumer.class);
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/ShortUuidGenerator.java
b/core/camel-support/src/main/java/org/apache/camel/support/ShortUuidGenerator.java
index fd942c8799cc..b2117b6bd92a 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/ShortUuidGenerator.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/ShortUuidGenerator.java
@@ -29,7 +29,7 @@ public class ShortUuidGenerator implements UuidGenerator {
private static final char[] HEX_ARRAY = "0123456789ABCDEF".toCharArray();
private final char[] seed
- = (seedToHex(ThreadLocalRandom.current().nextLong()).substring(1)
+ "-").toCharArray();
+ = (seedToHex(ThreadLocalRandom.current().nextLong()).substring(1)
+ "-").toCharArray(); // NOSONAR
private final AtomicLong index = new AtomicLong();
@Override
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/SingleInputTypedLanguageSupport.java
b/core/camel-support/src/main/java/org/apache/camel/support/SingleInputTypedLanguageSupport.java
index a88a3a203bf3..2d1e52fa4d54 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/SingleInputTypedLanguageSupport.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/SingleInputTypedLanguageSupport.java
@@ -68,7 +68,6 @@ public abstract class SingleInputTypedLanguageSupport extends
TypedLanguageSuppo
expression = loadResource(expression);
}
- Class<?> type = property(Class.class, properties, 0, null);
String source = property(String.class, properties, 1, null);
Expression input = ExpressionBuilder.singleInputExpression(source);
if (getCamelContext() != null) {
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/SynchronizationAdapter.java
b/core/camel-support/src/main/java/org/apache/camel/support/SynchronizationAdapter.java
index c219095444c0..266860073d0f 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/SynchronizationAdapter.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/SynchronizationAdapter.java
@@ -24,7 +24,7 @@ import org.apache.camel.spi.SynchronizationVetoable;
/**
* Simple {@link Synchronization} adapter with empty methods for easier
overriding of single methods.
*/
-public class SynchronizationAdapter implements SynchronizationVetoable,
Ordered, Synchronization {
+public class SynchronizationAdapter implements SynchronizationVetoable,
Ordered {
@Override
public void onComplete(Exchange exchange) {
onDone(exchange);
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java
b/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java
index cdd058c8aff1..91a072a273e9 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/cache/ServicePool.java
@@ -157,7 +157,6 @@ abstract class ServicePool<S extends Service> extends
ServiceSupport implements
/**
* Cleanup the pool (removing stale instances that should be evicted)
*/
- @SuppressWarnings("rawtypes")
public void cleanUp() {
if (cache instanceof LRUCache lru) {
lru.cleanUp();
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/component/EndpointUriFactorySupport.java
b/core/camel-support/src/main/java/org/apache/camel/support/component/EndpointUriFactorySupport.java
index 0036ae3e8562..7a5526b12d56 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/component/EndpointUriFactorySupport.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/component/EndpointUriFactorySupport.java
@@ -20,7 +20,6 @@ import java.util.Map;
import java.util.TreeMap;
import org.apache.camel.CamelContext;
-import org.apache.camel.CamelContextAware;
import org.apache.camel.spi.EndpointUriFactory;
import org.apache.camel.util.ObjectHelper;
import org.apache.camel.util.StringHelper;
@@ -30,7 +29,7 @@ import org.apache.camel.util.URISupport;
* Base class used by Camel Package Maven Plugin when it generates source code
for fast endpoint uri factory via
* {@link EndpointUriFactory}.
*/
-public abstract class EndpointUriFactorySupport implements CamelContextAware,
EndpointUriFactory {
+public abstract class EndpointUriFactorySupport implements EndpointUriFactory {
protected CamelContext camelContext;
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/processor/DelegateProcessor.java
b/core/camel-support/src/main/java/org/apache/camel/support/processor/DelegateProcessor.java
index b836b120453f..5f861f642caf 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/processor/DelegateProcessor.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/processor/DelegateProcessor.java
@@ -35,7 +35,7 @@ import org.apache.camel.support.service.ServiceSupport;
* @see DelegateAsyncProcessor
*/
public class DelegateProcessor extends ServiceSupport
- implements org.apache.camel.DelegateProcessor, Processor,
Navigate<Processor> {
+ implements org.apache.camel.DelegateProcessor, Navigate<Processor> {
protected Processor processor;
public DelegateProcessor() {
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/processor/ThroughputLogger.java
b/core/camel-support/src/main/java/org/apache/camel/support/processor/ThroughputLogger.java
index 9ebc7341b27d..c21e46a1634b 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/processor/ThroughputLogger.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/processor/ThroughputLogger.java
@@ -22,7 +22,6 @@ import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
import org.apache.camel.AsyncCallback;
-import org.apache.camel.AsyncProcessor;
import org.apache.camel.CamelContext;
import org.apache.camel.Exchange;
import org.apache.camel.spi.CamelLogger;
@@ -37,7 +36,7 @@ import org.slf4j.LoggerFactory;
/**
* A logger for logging message throughput.
*/
-public class ThroughputLogger extends AsyncProcessorSupport implements
AsyncProcessor, IdAware, RouteIdAware {
+public class ThroughputLogger extends AsyncProcessorSupport implements
IdAware, RouteIdAware {
private static final Logger LOG =
LoggerFactory.getLogger(ThroughputLogger.class);
diff --git
a/core/camel-support/src/main/java/org/apache/camel/support/scan/DefaultPackageScanResourceResolver.java
b/core/camel-support/src/main/java/org/apache/camel/support/scan/DefaultPackageScanResourceResolver.java
index b0e282537863..a9a4c601aeb0 100644
---
a/core/camel-support/src/main/java/org/apache/camel/support/scan/DefaultPackageScanResourceResolver.java
+++
b/core/camel-support/src/main/java/org/apache/camel/support/scan/DefaultPackageScanResourceResolver.java
@@ -34,7 +34,6 @@ import java.util.function.Predicate;
import java.util.jar.JarEntry;
import java.util.jar.JarInputStream;
-import org.apache.camel.CamelContextAware;
import org.apache.camel.NonManagedService;
import org.apache.camel.spi.PackageScanResourceResolver;
import org.apache.camel.spi.Resource;
@@ -50,7 +49,7 @@ import org.slf4j.LoggerFactory;
* Default implement of {@link
org.apache.camel.spi.PackageScanResourceResolver}
*/
public class DefaultPackageScanResourceResolver extends BasePackageScanResolver
- implements PackageScanResourceResolver, NonManagedService,
CamelContextAware {
+ implements PackageScanResourceResolver, NonManagedService {
private static final Logger LOG =
LoggerFactory.getLogger(DefaultPackageScanResourceResolver.class);
private static final AntPathMatcher PATH_MATCHER = AntPathMatcher.INSTANCE;
diff --git
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java
b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java
index f4d303a86f6a..1dcb930e9f2c 100644
---
a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java
+++
b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Run.java
@@ -1530,7 +1530,7 @@ public class Run extends CamelCommand {
Path logPath = null;
if (backgroundWait) {
// store background output in a log file to capture any error on
startup
- logPath = getRunBackgroundLogFile("" + new Random().nextLong());
+ logPath = getRunBackgroundLogFile("" + new Random().nextLong());
// NOSONAR
try {
Path logDir = CommandLineHelper.getCamelDir();
Files.createDirectories(logDir); //make sure the parent dir
exists
diff --git
a/test-infra/camel-test-infra-artemis/src/main/java/org/apache/camel/test/infra/artemis/services/AbstractArtemisEmbeddedService.java
b/test-infra/camel-test-infra-artemis/src/main/java/org/apache/camel/test/infra/artemis/services/AbstractArtemisEmbeddedService.java
index e2d505111f6c..fd1d6bf8820b 100644
---
a/test-infra/camel-test-infra-artemis/src/main/java/org/apache/camel/test/infra/artemis/services/AbstractArtemisEmbeddedService.java
+++
b/test-infra/camel-test-infra-artemis/src/main/java/org/apache/camel/test/infra/artemis/services/AbstractArtemisEmbeddedService.java
@@ -112,7 +112,7 @@ public abstract class AbstractArtemisEmbeddedService
implements ArtemisInfraServ
private static String getRandomSubPath() {
final int size = 12;
- return ThreadLocalRandom.current().ints(97, 122)
+ return ThreadLocalRandom.current().ints(97, 122) // NOSONAR
.limit(size)
.collect(StringBuilder::new, StringBuilder::appendCodePoint,
StringBuilder::append)
.toString();
