CAMEL-9641: Simple backwards parser bug if using file as prefix
Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/0363a727 Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/0363a727 Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/0363a727 Branch: refs/heads/camel-2.16.x Commit: 0363a7274d3082bb32d1ac9508b8d38998278d82 Parents: e077fdf Author: Claus Ibsen <davscl...@apache.org> Authored: Wed Feb 24 16:56:24 2016 +0100 Committer: Claus Ibsen <davscl...@apache.org> Committed: Wed Feb 24 17:31:12 2016 +0100 ---------------------------------------------------------------------- .../language/simple/ast/SimpleFunctionExpression.java | 11 +++++++---- .../org/apache/camel/language/simple/SimpleTest.java | 4 ++++ 2 files changed, 11 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/0363a727/camel-core/src/main/java/org/apache/camel/language/simple/ast/SimpleFunctionExpression.java ---------------------------------------------------------------------- diff --git a/camel-core/src/main/java/org/apache/camel/language/simple/ast/SimpleFunctionExpression.java b/camel-core/src/main/java/org/apache/camel/language/simple/ast/SimpleFunctionExpression.java index d2fd1ca..1582b26 100644 --- a/camel-core/src/main/java/org/apache/camel/language/simple/ast/SimpleFunctionExpression.java +++ b/camel-core/src/main/java/org/apache/camel/language/simple/ast/SimpleFunctionExpression.java @@ -141,8 +141,8 @@ public class SimpleFunctionExpression extends LiteralExpression { // file: prefix remainder = ifStartsWithReturnRemainder("file:", function); if (remainder != null) { - Expression fileExpression = createSimpleFileExpression(remainder); - if (function != null) { + Expression fileExpression = createSimpleFileExpression(remainder, strict); + if (fileExpression != null) { return fileExpression; } } @@ -376,7 +376,7 @@ public class SimpleFunctionExpression extends LiteralExpression { return null; } - private Expression createSimpleFileExpression(String remainder) { + private Expression createSimpleFileExpression(String remainder, boolean strict) { if (ObjectHelper.equal(remainder, "name")) { return ExpressionBuilder.fileNameExpression(); } else if (ObjectHelper.equal(remainder, "name.noext")) { @@ -406,7 +406,10 @@ public class SimpleFunctionExpression extends LiteralExpression { } else if (ObjectHelper.equal(remainder, "modified")) { return ExpressionBuilder.fileLastModifiedExpression(); } - throw new SimpleParserException("Unknown file language syntax: " + remainder, token.getIndex()); + if (strict) { + throw new SimpleParserException("Unknown file language syntax: " + remainder, token.getIndex()); + } + return null; } private String ifStartsWithReturnRemainder(String prefix, String text) { http://git-wip-us.apache.org/repos/asf/camel/blob/0363a727/camel-core/src/test/java/org/apache/camel/language/simple/SimpleTest.java ---------------------------------------------------------------------- diff --git a/camel-core/src/test/java/org/apache/camel/language/simple/SimpleTest.java b/camel-core/src/test/java/org/apache/camel/language/simple/SimpleTest.java index b0b5106..4d8f31f 100644 --- a/camel-core/src/test/java/org/apache/camel/language/simple/SimpleTest.java +++ b/camel-core/src/test/java/org/apache/camel/language/simple/SimpleTest.java @@ -105,6 +105,10 @@ public class SimpleTest extends LanguageTestSupport { assertNull(SimpleLanguage.simple("${null}").evaluate(exchange, Object.class)); } + public void testSimpleFileDir() throws Exception { + assertExpression("file:mydir", "file:mydir"); + } + public void testEmptyExpression() throws Exception { assertExpression("", ""); assertExpression(" ", " ");
