Repository: camel Updated Branches: refs/heads/master b121af112 -> 391b6e679
cleanup camel-kafka/test's system.out.println usage Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/391b6e67 Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/391b6e67 Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/391b6e67 Branch: refs/heads/master Commit: 391b6e679c1d3c28f744e0740cd371efca59be71 Parents: b121af1 Author: Akitoshi Yoshida <a...@apache.org> Authored: Wed Feb 3 16:00:26 2016 +0100 Committer: Akitoshi Yoshida <a...@apache.org> Committed: Wed Feb 3 16:00:26 2016 +0100 ---------------------------------------------------------------------- .../apache/camel/component/kafka/BaseEmbeddedKafkaTest.java | 9 ++++++--- .../component/kafka/embedded/EmbeddedKafkaCluster.java | 6 +++++- 2 files changed, 11 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/391b6e67/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/BaseEmbeddedKafkaTest.java ---------------------------------------------------------------------- diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/BaseEmbeddedKafkaTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/BaseEmbeddedKafkaTest.java index 4c6f18f..0d2b003 100644 --- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/BaseEmbeddedKafkaTest.java +++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/BaseEmbeddedKafkaTest.java @@ -30,12 +30,15 @@ import org.apache.camel.test.AvailablePortFinder; import org.apache.camel.test.junit4.CamelTestSupport; import org.junit.AfterClass; import org.junit.BeforeClass; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class BaseEmbeddedKafkaTest extends CamelTestSupport { - static EmbeddedZookeeper embeddedZookeeper; static EmbeddedKafkaCluster embeddedKafkaCluster; + private static final Logger LOG = LoggerFactory.getLogger(BaseEmbeddedKafkaTest.class); + private static volatile int zookeeperPort; private static volatile int karfkaPort; @@ -57,9 +60,9 @@ public class BaseEmbeddedKafkaTest extends CamelTestSupport { } catch (IOException e) { e.printStackTrace(); } - System.out.println("### Embedded Zookeeper connection: " + embeddedZookeeper.getConnection()); + LOG.info("Embedded Zookeeper connection: " + embeddedZookeeper.getConnection()); embeddedKafkaCluster.startup(); - System.out.println("### Embedded Kafka cluster broker list: " + embeddedKafkaCluster.getBrokerList()); + LOG.info("Embedded Kafka cluster broker list: " + embeddedKafkaCluster.getBrokerList()); } @AfterClass http://git-wip-us.apache.org/repos/asf/camel/blob/391b6e67/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/embedded/EmbeddedKafkaCluster.java ---------------------------------------------------------------------- diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/embedded/EmbeddedKafkaCluster.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/embedded/EmbeddedKafkaCluster.java index 24a80a2..ce11a47 100644 --- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/embedded/EmbeddedKafkaCluster.java +++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/embedded/EmbeddedKafkaCluster.java @@ -27,9 +27,13 @@ import kafka.admin.AdminUtils; import kafka.server.KafkaConfig; import kafka.server.KafkaServer; import kafka.utils.ZkUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import scala.Option; public class EmbeddedKafkaCluster { + private static final Logger LOG = LoggerFactory.getLogger(EmbeddedKafkaCluster.class); + private final List<Integer> ports; private final String zkConnection; private final Properties baseProperties; @@ -110,8 +114,8 @@ public class EmbeddedKafkaCluster { properties.setProperty("log.dir", logDir.getAbsolutePath()); properties.setProperty("num.partitions", String.valueOf(1)); properties.setProperty("auto.create.topics.enable", String.valueOf(Boolean.TRUE)); - System.out.println("EmbeddedKafkaCluster: local directory: " + logDir.getAbsolutePath()); properties.setProperty("log.flush.interval.messages", String.valueOf(1)); + LOG.info("EmbeddedKafkaCluster: local directory: " + logDir.getAbsolutePath()); KafkaServer broker = startBroker(properties);
