bvahdat commented on PR #19110: URL: https://github.com/apache/camel/pull/19110#issuecomment-3291577649
> If the code in `RestOpenApiSupport#getJsonFromOpenAPIAsString` can be called concurrently (I am not sure you are confirming that's the case), then no, it would not be the case that issue #7717 is re-introduced again. That would be a different issue, caused by some racing internals of `SimpleDateFormat`. That issue was neither introduced nor worsened by the current PR. So if somebody confirms that `RestOpenApiSupport#getJsonFromOpenAPIAsString` can really be called concurrently, than `RestOpenApiSupport.DEFAULT_DATE_FORMAT` has to be transformed to a thread local or inlined into `getJsonFromOpenAPIAsString()`. I'm not much familiar with the codebase but the static signature of `RestOpenApiSupport#getJsonFromOpenAPIAsString` smells after that but I'm not sure. cc: @zhfeng @oscerd @davsclaus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
