jamesnetherton commented on issue #7316: URL: https://github.com/apache/camel-quarkus/issues/7316#issuecomment-2853715242
Although there's a bug here, I don't see the value in having [SqlConfigSourceFactory](https://github.com/apache/camel-quarkus/blob/2d8aa0c2f758885c0395ad0bd9ea9e546d52b944/integration-tests/sql/src/main/java/org/apache/camel/quarkus/component/sql/it/SqlConfigSourceFactory.java#L45). It seems to do two things: 1. Sets various `quarkus.datasource` properties from environment variables 2. Configures Derby for in-container or non-container testing All of the `quarkus.datasource` config options are already capable of being set via environment variables, so item 1 is redundant. All Derby testing uses the Quarkus dev service, so 2 is also not needed. So I propose to remove `SqlConfigSourceFactory` and update the SQL itest README notes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
