Removed commons-lang3 dependency and added same functionality to camel-netty-http component
Project: http://git-wip-us.apache.org/repos/asf/camel/repo Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/91812a56 Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/91812a56 Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/91812a56 Branch: refs/heads/master Commit: 91812a5658d2a401eaa7b19618ac17a8c0343dde Parents: bd04ab1 Author: Askannon <askan...@flexarc.com> Authored: Sun Sep 27 22:36:32 2015 +0200 Committer: Claus Ibsen <davscl...@apache.org> Committed: Mon Sep 28 07:19:09 2015 +0200 ---------------------------------------------------------------------- .../netty/http/NettyHttpComponent.java | 7 ++ ...stNettyHttpContextPathConfigurationTest.java | 68 ++++++++++++++++++++ .../netty4/http/NettyHttpComponent.java | 3 +- 3 files changed, 76 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/camel/blob/91812a56/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpComponent.java ---------------------------------------------------------------------- diff --git a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpComponent.java b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpComponent.java index 0ce17c6..2763256 100644 --- a/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpComponent.java +++ b/components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpComponent.java @@ -271,6 +271,13 @@ public class NettyHttpComponent extends NettyComponent implements HeaderFilterSt port = num; } + String contextPath = config.getContextPath(); + if(ObjectHelper.isNotEmpty(contextPath)) { + contextPath = FileUtil.stripTrailingSeparator(contextPath); + contextPath = FileUtil.stripLeadingSeparator(contextPath); + path = contextPath + "/" + path; + } + // if no explicit hostname set then resolve the hostname if (ObjectHelper.isEmpty(host)) { if (config.getRestHostNameResolver() == RestConfiguration.RestHostNameResolver.localHostName) { http://git-wip-us.apache.org/repos/asf/camel/blob/91812a56/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpContextPathConfigurationTest.java ---------------------------------------------------------------------- diff --git a/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpContextPathConfigurationTest.java b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpContextPathConfigurationTest.java new file mode 100644 index 0000000..4a7c559 --- /dev/null +++ b/components/camel-netty-http/src/test/java/org/apache/camel/component/netty/http/rest/RestNettyHttpContextPathConfigurationTest.java @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.netty.http.rest; + +import org.apache.camel.Exchange; +import org.apache.camel.Processor; +import org.apache.camel.builder.RouteBuilder; +import org.apache.camel.component.netty.http.BaseNettyTest; +import org.junit.Test; + +public class RestNettyHttpContextPathConfigurationTest extends BaseNettyTest { + + @Test + public void testProducerGet() throws Exception { + String out = template.requestBody("netty-http:http://localhost:{{port}}/rest/users/123";, null, String.class); + assertEquals("123;Donald Duck", out); + + out = template.requestBody("netty-http:http://localhost:{{port}}/rest/users/list";, null, String.class); + assertEquals("123;Donald Duck\n456;John Doe", out); + } + + @Override + protected RouteBuilder createRouteBuilder() throws Exception { + return new RouteBuilder() { + @Override + public void configure() throws Exception { + // configure to use netty-http on localhost with the given port + restConfiguration().component("netty-http").host("localhost").contextPath("/rest").port(getPort()); + + // use the rest DSL to define the rest services + rest("/users/") + .get("{id}") + .route() + .to("mock:input") + .process(new Processor() { + public void process(Exchange exchange) throws Exception { + String id = exchange.getIn().getHeader("id", String.class); + exchange.getOut().setBody(id + ";Donald Duck"); + } + }) + .endRest() + .get("list") + .route() + .to("mock:input") + .process(new Processor() { + public void process(Exchange exchange) throws Exception { + exchange.getOut().setBody("123;Donald Duck\n456;John Doe"); + } + }); + } + }; + } + +} http://git-wip-us.apache.org/repos/asf/camel/blob/91812a56/components/camel-netty4-http/src/main/java/org/apache/camel/component/netty4/http/NettyHttpComponent.java ---------------------------------------------------------------------- diff --git a/components/camel-netty4-http/src/main/java/org/apache/camel/component/netty4/http/NettyHttpComponent.java b/components/camel-netty4-http/src/main/java/org/apache/camel/component/netty4/http/NettyHttpComponent.java index 7e2cbc2..bf104c4 100644 --- a/components/camel-netty4-http/src/main/java/org/apache/camel/component/netty4/http/NettyHttpComponent.java +++ b/components/camel-netty4-http/src/main/java/org/apache/camel/component/netty4/http/NettyHttpComponent.java @@ -41,7 +41,6 @@ import org.apache.camel.util.ObjectHelper; import org.apache.camel.util.ServiceHelper; import org.apache.camel.util.URISupport; import org.apache.camel.util.UnsafeUriCharactersEncoder; -import org.apache.commons.lang3.StringUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -272,7 +271,7 @@ public class NettyHttpComponent extends NettyComponent implements HeaderFilterSt } String contextPath = config.getContextPath(); - if(StringUtils.isNotEmpty(contextPath)) { + if(ObjectHelper.isNotEmpty(contextPath)) { contextPath = FileUtil.stripTrailingSeparator(contextPath); contextPath = FileUtil.stripLeadingSeparator(contextPath); path = contextPath + "/" + path;
