This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/main by this push:
     new 98ca559b7af CAMEL-21874 Fixed 3 cases of possible resource leak 
(#17463)
98ca559b7af is described below

commit 98ca559b7afaf9ec08c6b1a2b36c8252817ae081
Author: Dmitry Kryukov <d...@users.noreply.github.com>
AuthorDate: Tue Mar 18 11:07:08 2025 +0300

    CAMEL-21874 Fixed 3 cases of possible resource leak (#17463)
    
    * CAMEL-21874 Fixed 3 cases of possible resource leak
    
    * CAMEL-21874 Fixed formatting
---
 .../aws2/firehose/KinesisFirehose2ComponentVerifierExtension.java  | 7 ++++---
 .../camel/component/aws2/kms/KMS2ComponentVerifierExtension.java   | 7 ++++---
 .../camel/component/aws2/sts/STS2ComponentVerifierExtension.java   | 7 ++++---
 3 files changed, 12 insertions(+), 9 deletions(-)

diff --git 
a/components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/firehose/KinesisFirehose2ComponentVerifierExtension.java
 
b/components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/firehose/KinesisFirehose2ComponentVerifierExtension.java
index 527b724eeea..a7855d96eca 100644
--- 
a/components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/firehose/KinesisFirehose2ComponentVerifierExtension.java
+++ 
b/components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/firehose/KinesisFirehose2ComponentVerifierExtension.java
@@ -77,9 +77,10 @@ public class KinesisFirehose2ComponentVerifierExtension 
extends DefaultComponent
             }
             AwsBasicCredentials cred = 
AwsBasicCredentials.create(configuration.getAccessKey(), 
configuration.getSecretKey());
             FirehoseClientBuilder clientBuilder = FirehoseClient.builder();
-            FirehoseClient client = 
clientBuilder.credentialsProvider(StaticCredentialsProvider.create(cred))
-                    .region(Region.of(configuration.getRegion())).build();
-            client.listDeliveryStreams();
+            try (FirehoseClient client = 
clientBuilder.credentialsProvider(StaticCredentialsProvider.create(cred))
+                    .region(Region.of(configuration.getRegion())).build()) {
+                client.listDeliveryStreams();
+            }
         } catch (SdkClientException e) {
             ResultErrorBuilder errorBuilder
                     = 
ResultErrorBuilder.withCodeAndDescription(VerificationError.StandardCode.AUTHENTICATION,
 e.getMessage())
diff --git 
a/components/camel-aws/camel-aws2-kms/src/main/java/org/apache/camel/component/aws2/kms/KMS2ComponentVerifierExtension.java
 
b/components/camel-aws/camel-aws2-kms/src/main/java/org/apache/camel/component/aws2/kms/KMS2ComponentVerifierExtension.java
index 9cb4e3a9e73..bbe7d5e8352 100644
--- 
a/components/camel-aws/camel-aws2-kms/src/main/java/org/apache/camel/component/aws2/kms/KMS2ComponentVerifierExtension.java
+++ 
b/components/camel-aws/camel-aws2-kms/src/main/java/org/apache/camel/component/aws2/kms/KMS2ComponentVerifierExtension.java
@@ -75,9 +75,10 @@ public class KMS2ComponentVerifierExtension extends 
DefaultComponentVerifierExte
             }
             AwsBasicCredentials cred = 
AwsBasicCredentials.create(configuration.getAccessKey(), 
configuration.getSecretKey());
             KmsClientBuilder clientBuilder = KmsClient.builder();
-            KmsClient client = 
clientBuilder.credentialsProvider(StaticCredentialsProvider.create(cred))
-                    .region(Region.of(configuration.getRegion())).build();
-            client.listKeys();
+            try (KmsClient client = 
clientBuilder.credentialsProvider(StaticCredentialsProvider.create(cred))
+                    .region(Region.of(configuration.getRegion())).build()) {
+                client.listKeys();
+            }
         } catch (SdkClientException e) {
             ResultErrorBuilder errorBuilder
                     = 
ResultErrorBuilder.withCodeAndDescription(VerificationError.StandardCode.AUTHENTICATION,
 e.getMessage())
diff --git 
a/components/camel-aws/camel-aws2-sts/src/main/java/org/apache/camel/component/aws2/sts/STS2ComponentVerifierExtension.java
 
b/components/camel-aws/camel-aws2-sts/src/main/java/org/apache/camel/component/aws2/sts/STS2ComponentVerifierExtension.java
index e721feddc2e..a6c5c7d78c2 100644
--- 
a/components/camel-aws/camel-aws2-sts/src/main/java/org/apache/camel/component/aws2/sts/STS2ComponentVerifierExtension.java
+++ 
b/components/camel-aws/camel-aws2-sts/src/main/java/org/apache/camel/component/aws2/sts/STS2ComponentVerifierExtension.java
@@ -76,9 +76,10 @@ public class STS2ComponentVerifierExtension extends 
DefaultComponentVerifierExte
             }
             AwsBasicCredentials cred = 
AwsBasicCredentials.create(configuration.getAccessKey(), 
configuration.getSecretKey());
             StsClientBuilder clientBuilder = StsClient.builder();
-            StsClient client = 
clientBuilder.credentialsProvider(StaticCredentialsProvider.create(cred))
-                    .region(Region.of(configuration.getRegion())).build();
-            client.serviceName();
+            try (StsClient client = 
clientBuilder.credentialsProvider(StaticCredentialsProvider.create(cred))
+                    .region(Region.of(configuration.getRegion())).build()) {
+                client.serviceName();
+            }
         } catch (SdkClientException e) {
             ResultErrorBuilder errorBuilder
                     = 
ResultErrorBuilder.withCodeAndDescription(VerificationError.StandardCode.AUTHENTICATION,
 e.getMessage())

Reply via email to