tadayosi commented on code in PR #17593:
URL: https://github.com/apache/camel/pull/17593#discussion_r2017960529
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/version/VersionSet.java:
##########
@@ -43,13 +43,16 @@ public class VersionSet extends CamelCommand {
@CommandLine.Option(names = { "--reset" }, description = "Reset by
removing any custom version settings")
boolean reset;
+ @CommandLine.Option(names = { "--local" }, description = "Retrieve
configurations from current directory")
Review Comment:
"Store ... to" over "Retrieve ... from"
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/config/ConfigUnset.java:
##########
@@ -28,6 +28,9 @@ public class ConfigUnset extends CamelCommand {
@CommandLine.Parameters(description = "Configuration key", arity = "1")
String key;
+ @CommandLine.Option(names = { "--local" }, description = "Retrieve
configurations from current directory")
Review Comment:
"Unset" instead of "Retrieve"
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/config/ConfigSet.java:
##########
@@ -29,13 +29,16 @@ public class ConfigSet extends CamelCommand {
@CommandLine.Parameters(description = "Configuration parameter (ex.
key=value)", arity = "1")
String configuration;
+ @CommandLine.Option(names = { "--local" }, description = "Retrieve
configurations from current directory")
Review Comment:
The wording should be "Store ... to" instead of "Retrieve ... from" here.
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/version/VersionSet.java:
##########
@@ -43,13 +43,16 @@ public class VersionSet extends CamelCommand {
@CommandLine.Option(names = { "--reset" }, description = "Reset by
removing any custom version settings")
boolean reset;
+ @CommandLine.Option(names = { "--local" }, description = "Retrieve
configurations from current directory")
Review Comment:
Or if we want the same wording for all options, we should consider a more
generic wording. Examples:
"Apply configrations to current directoyr", or
"Use local configurations instead of global"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
