This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push: new 78a89662a4b CAMEL-21739: camel-ftp - Add filename to implementation of GenericFileConsumer.getRelativeFilePath for (S)FTP (#17143) 78a89662a4b is described below commit 78a89662a4b3fad918518983bcb1fff41782895a Author: Benjamin Graf <gra...@users.noreply.github.com> AuthorDate: Fri Feb 14 20:41:24 2025 +0100 CAMEL-21739: camel-ftp - Add filename to implementation of GenericFileConsumer.getRelativeFilePath for (S)FTP (#17143) --- .../camel/component/file/remote/FtpConsumer.java | 2 +- .../camel/component/file/remote/SftpConsumer.java | 2 +- .../SftpSimpleConsumeWithAntIncludeIT.java | 59 ++++++++++++++++++++++ 3 files changed, 61 insertions(+), 2 deletions(-) diff --git a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpConsumer.java b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpConsumer.java index 2b7c5dced54..411ad70d4c0 100644 --- a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpConsumer.java +++ b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/FtpConsumer.java @@ -321,7 +321,7 @@ public class FtpConsumer extends RemoteFileConsumer<FTPFile> { // the relative filename, skip the leading endpoint configured path String relativePath = StringHelper.after(absolutePath, endpointPath); // skip leading / - return FileUtil.stripLeadingSeparator(relativePath); + return FileUtil.stripLeadingSeparator(relativePath) + "/" + file.getName(); }; } diff --git a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpConsumer.java b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpConsumer.java index d27e336ba6c..4e7b2018871 100644 --- a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpConsumer.java +++ b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpConsumer.java @@ -274,7 +274,7 @@ public class SftpConsumer extends RemoteFileConsumer<SftpRemoteFile> { return () -> { String relativePath = StringHelper.after(absolutePath, endpointPath); // skip trailing / - return FileUtil.stripLeadingSeparator(relativePath); + return FileUtil.stripLeadingSeparator(relativePath) + "/" + file.getFilename(); }; } diff --git a/components/camel-ftp/src/test/java/org/apache/camel/component/file/remote/sftp/integration/SftpSimpleConsumeWithAntIncludeIT.java b/components/camel-ftp/src/test/java/org/apache/camel/component/file/remote/sftp/integration/SftpSimpleConsumeWithAntIncludeIT.java new file mode 100644 index 00000000000..25a40c635b3 --- /dev/null +++ b/components/camel-ftp/src/test/java/org/apache/camel/component/file/remote/sftp/integration/SftpSimpleConsumeWithAntIncludeIT.java @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.file.remote.sftp.integration; + +import org.apache.camel.Exchange; +import org.apache.camel.builder.RouteBuilder; +import org.apache.camel.component.mock.MockEndpoint; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.condition.EnabledIf; + +@EnabledIf(value = "org.apache.camel.test.infra.ftp.services.embedded.SftpUtil#hasRequiredAlgorithms('src/test/resources/hostkey.pem')") +public class SftpSimpleConsumeWithAntIncludeIT extends SftpServerTestSupport { + + @Test + public void testSftpSimpleConsume() throws Exception { + String expected = "Hello World"; + + // create file using regular file + template.sendBodyAndHeader("file://" + service.getFtpRootDir(), expected, Exchange.FILE_NAME, "subdir/hello.txt"); + + MockEndpoint mock = getMockEndpoint("mock:result"); + mock.expectedMessageCount(1); + mock.expectedHeaderReceived(Exchange.FILE_NAME, "hello.txt"); + mock.expectedBodiesReceived(expected); + + context.getRouteController().startRoute("foo"); + + MockEndpoint.assertIsSatisfied(context); + } + + @Override + protected RouteBuilder createRouteBuilder() { + return new RouteBuilder() { + @Override + public void configure() { + from("sftp://localhost:{{ftp.server.port}}/{{ftp.root.dir}}" + + "?username=admin&password=admin&delay=10000&disconnect=true" + + "&recursive=true&antInclude=subdir/hello.txt" + + "&knownHostsFile=" + + service.getKnownHostsFile()).routeId("foo").noAutoStartup() + .to("mock:result"); + } + }; + } +}