JiriOndrusek opened a new pull request, #6935:
URL: https://github.com/apache/camel-quarkus/pull/6935

   fixes https://github.com/apache/camel-quarkus/issues/6690
   fixes https://github.com/apache/camel-quarkus/issues/6933
   
   Google-secret-manager native support is added:
   
   - tech preview status is changed to stable
   - extension and tests are moved from **JVM** modules into standard one
   - native support requires duplication of some code (which is already present 
in google-pubsub). The refactor is not part of this PR (as it would make the 
whole change more complicated). I created a ticket 
https://github.com/apache/camel-quarkus/issues/6934 to do such refactor in the 
future.
   
   
   Test coverage is added:
   - the real backend is required (as was before)
   - pubsub test resource had to be added to simulate the sending of the 
message to the secret refresh topic (see more details in the comment of 
`GoogleSecretManagerTest` class)
   
   
   <!-- Uncomment and fill this section if your PR is not trivial
   [ ] An issue should be filed for the change unless this is a trivial change 
(fixing a typo or similar). One issue should ideally be fixed by not more than 
one commit and the other way round, each commit should fix just one issue, 
without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful and properly 
spelled subject line and body. Copying the title of the associated issue is 
typically enough. Please include the issue number in the commit message 
prefixed by #.
   [ ] The pull request description should explain what the pull request does, 
how, and why. If the info is available in the associated issue or some other 
external document, a link is enough.
   [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close 
the named issue upon merging the pull request. Using them is typically a good 
idea.
   [ ] Please run mvn process-resources -Pformat (and amend the changes if 
necessary) before sending the pull request.
   [ ] Contributor guide is your good friend: 
https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to