Croway commented on code in PR #21: URL: https://github.com/apache/camel-upgrade-recipes/pull/21#discussion_r1925721320
########## camel-spring-boot-upgrade-recipes/pom.xml: ########## @@ -33,7 +33,8 @@ <description>Migration recipes (using openrewrite) for Camel Spring Boot to make Maven migrations easier</description> <properties> - <spring-rewrite-version>5.24.1</spring-rewrite-version> + <!-- Update this with each spring-rewrite release --> + <spring-rewrite-version>6.0.1</spring-rewrite-version> Review Comment: Sorry to bother you @timtebeek , but I think this situation is a corner case, the Apache Camel release 4.9.0 uses Spring Boot 3.4.x, but the upgrade for SB 3.4 has not released yet, therefore I think we have the following approaches: - Wait for the SB 3_4 recipe release before releasing camel-upgrade-recipes 4.9.0 (not great from my point of view, @davsclaus do you have any comment about it?) - Use the SpringBoot_3_3 upgrade recipe and update Spring Boot versions to 3.4.x via org.openrewrite.maven.UpgradeDependencyVersion (there may be issues, SB upgrades are stable, but you never know..) - Do not upgrade Spring Boot at all Do you have any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org