orpiske commented on code in PR #16804:
URL: https://github.com/apache/camel/pull/16804#discussion_r1916064652
##########
test-infra/camel-test-infra-couchdb/src/main/resources/org/apache/camel/test/infra/couchdb/services/container.properties:
##########
@@ -15,4 +15,5 @@
## limitations under the License.
## ---------------------------------------------------------------------------
## tested against 2.1.2, 2.2.0 & 2.3.1
-couchdb.container=mirror.gcr.io/couchdb:2.3.1
\ No newline at end of file
+couchdb.container=mirror.gcr.io/couchdb:2.3.1
+couchdb.container.ppc64le=ppc64le/couchdb:2.3.1
Review Comment:
One more question: from which registry is this one coming from?
##########
test-infra/camel-test-infra-couchdb/src/main/java/org/apache/camel/test/infra/couchdb/services/CouchDbLocalContainerInfraService.java:
##########
@@ -35,7 +36,15 @@ public class CouchDbLocalContainerInfraService implements
CouchDbInfraService, C
public CouchDbLocalContainerInfraService() {
this(LocalPropertyResolver.getProperty(
CouchDbLocalContainerInfraService.class,
- CouchDbProperties.COUCHDB_CONTAINER));
+ getPropertyKeyForContainerImage()));
+ }
+
+ private static String getPropertyKeyForContainerImage() {
+ if ("ppc64le".equals(SystemUtils.OS_ARCH)) {
+ return CouchDbProperties.COUCHDB_CONTAINER_PPC64LE;
+ } else {
+ return CouchDbProperties.COUCHDB_CONTAINER;
+ }
Review Comment:
None of these lines are needed
##########
test-infra/camel-test-infra-couchdb/src/main/java/org/apache/camel/test/infra/couchdb/common/CouchDbProperties.java:
##########
@@ -23,6 +23,7 @@ public final class CouchDbProperties {
public static final String PORT = "couchdb.port";
public static final int DEFAULT_PORT = 5984;
public static final String COUCHDB_CONTAINER = "couchdb.container";
+ public static final String COUCHDB_CONTAINER_PPC64LE =
"couchdb.container.ppc64le";
Review Comment:
Not needed
##########
test-infra/camel-test-infra-couchdb/src/main/resources/org/apache/camel/test/infra/couchdb/services/container.properties:
##########
@@ -15,4 +15,5 @@
## limitations under the License.
## ---------------------------------------------------------------------------
## tested against 2.1.2, 2.2.0 & 2.3.1
-couchdb.container=mirror.gcr.io/couchdb:2.3.1
\ No newline at end of file
+couchdb.container=mirror.gcr.io/couchdb:2.3.1
+couchdb.container.ppc64le=ppc64le/couchdb:2.3.1
Review Comment:
If coming from Docker Hub, then it should use `mirror.gcr.io` instead of
pulling directly from the Docker Hub.
##########
test-infra/camel-test-infra-couchdb/src/main/resources/org/apache/camel/test/infra/couchdb/services/container.properties:
##########
@@ -15,4 +15,5 @@
## limitations under the License.
## ---------------------------------------------------------------------------
## tested against 2.1.2, 2.2.0 & 2.3.1
-couchdb.container=mirror.gcr.io/couchdb:2.3.1
\ No newline at end of file
+couchdb.container=mirror.gcr.io/couchdb:2.3.1
+couchdb.container.ppc64le=ppc64le/couchdb:2.3.1
Review Comment:
i.e.: `mirror.gcr.io/ppc64le/couchdb:2.3.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
