mikey-austin opened a new pull request, #16650:
URL: https://github.com/apache/camel/pull/16650

   # Description
   
   tl;dr
   - make KCL application name configurable
   - allow a custom _async_ kinesis client instance to be configured
   
   The KCL application name is important to define, as the underlying AWS 
Kinesis library will use this application name as the basis for the dynamodb 
lease table(s) that it manages. My use case required the Kinesis stream name to 
differ from the dynamodb lease table name, and this was not possible due to the 
streamName being hard-coded to equal the applicationName when instantiating the 
AWS KCL consumer.
   
   Also allow a pre-constructed async Kinesis client instance to be configured 
in the same manner as the non-async Kinesis client. My use case requires a 
custom AWS credentials provider, which meant that it was not possible before to 
use the existing async client builder capability in this module.
   
   # Target
   
   - [x] I checked that the commit is targeting the correct branch (note that 
Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
   
   # Tracking
   - [x] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   <!--
   # *Note*: trivial changes like, typos, minor documentation fixes and other 
small items do not require a JIRA issue. In this case your pull request should 
address just this issue, without pulling in other changes.
   -->
   
   # Apache Camel coding standards and style
   
   - [x] I checked that each commit in the pull request has a meaningful 
subject line and body.
   
   <!--
   If you're unsure, you can format the pull request title like `[CAMEL-XXX] 
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the 
appropriate JIRA issue.
   -->
   
   - [x] I have run `mvn clean install -DskipTests` locally from root folder 
and I have committed all auto-generated changes.
   
   <!--
   You can run the aforementioned command in your module so that the build 
auto-formats your code. This will also be verified as part of the checks and 
your PR may be rejected if if there are uncommited changes after running `mvn 
clean install -DskipTests`.
   
   You can learn more about the contribution guidelines at 
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to