thomas-gantenbein-tga commented on PR #16386: URL: https://github.com/apache/camel/pull/16386#issuecomment-2506728977
I've cherry-picked this commit on top of ff5caa5b999 and ran my reproducer. The result: No, let's not merge this. Whatever was changed between ff5caa5b999 and release 4.8.1 fixed the issue of the same traceId being generated every time a consumer thread would start an exchange. Given this fix, my own "fix" on top of it even makes things slightly worse: Where I invoke the netty route without a traceparent header, thread #3 now gets a brand-new traceId, same for thread #6 in the last netty route: ``` 21:08:33.366 INFO Camel (camel-1) thread #2 - timer://mytimer [3e79d97fa497733fd51565e48c4bc79a,5caae76825597471] timer - in timer route 21:08:33.377 INFO Camel (camel-1) thread #2 - timer://mytimer [3e79d97fa497733fd51565e48c4bc79a,0e35b3bee30a48d6] route1 - in aSlowerRoute 21:08:33.468 INFO Camel (camel-1) thread #3 - Delay [,] route1 - still in aSlowerRoute 21:08:33.471 INFO Camel (camel-1) thread #3 - Delay [3e79d97fa497733fd51565e48c4bc79a,95e1d7d8028296e0] route2 - in aFasterRoute 21:08:33.498 INFO Camel (camel-1) thread #4 - Delay [,] route2 - still in aFasterRoute 21:08:38.255 INFO Camel (camel-1) thread #2 - timer://mytimer [8a6688d4bff62bf0d1444ff0d9aaa210,d8457081e524cdcc] timer - in timer route 21:08:38.256 INFO Camel (camel-1) thread #2 - timer://mytimer [8a6688d4bff62bf0d1444ff0d9aaa210,9d32d658a3986dfc] route1 - in aSlowerRoute 21:08:38.338 INFO Camel (camel-1) thread #3 - Delay [3e79d97fa497733fd51565e48c4bc79a,95e1d7d8028296e0] route1 - still in aSlowerRoute 21:08:38.340 INFO Camel (camel-1) thread #3 - Delay [8a6688d4bff62bf0d1444ff0d9aaa210,b77cf7ed75eb0941] route2 - in aFasterRoute 21:08:38.385 INFO Camel (camel-1) thread #4 - Delay [,] route2 - still in aFasterRoute 21:08:57.929 INFO Camel (camel-1) thread #8 - NettyConsumerExecutorGroup [35e0dec31ec26df1204f91caa8f95091,c0a1af17056cb737] netty - in netty route 21:08:57.930 INFO Camel (camel-1) thread #8 - NettyConsumerExecutorGroup [35e0dec31ec26df1204f91caa8f95091,e5cb71ad5987aa99] route1 - in aSlowerRoute 21:08:58.062 INFO Camel (camel-1) thread #5 - Delay [a794c504464d2e41a73370554b431788,d4afe0b75c1c773b] route1 - still in aSlowerRoute 21:08:58.064 INFO Camel (camel-1) thread #5 - Delay [35e0dec31ec26df1204f91caa8f95091,3cae953a6f3821e4] route2 - in aFasterRoute 21:08:58.097 INFO Camel (camel-1) thread #6 - Delay [a794c504464d2e41a73370554b431788,d4afe0b75c1c773b] route2 - still in aFasterRoute 21:08:58.146 INFO Camel (camel-1) thread #12 - NettyConsumerExecutorGroup [4bf92f3577b34da6a3ce929d0e0e4739,9bcb9c18fe6b3547] netty - in netty route 21:08:58.148 INFO Camel (camel-1) thread #12 - NettyConsumerExecutorGroup [4bf92f3577b34da6a3ce929d0e0e4739,6504a15fc75cc4f7] route1 - in aSlowerRoute 21:08:58.482 INFO Camel (camel-1) thread #3 - Delay [8a6688d4bff62bf0d1444ff0d9aaa210,b77cf7ed75eb0941] route1 - still in aSlowerRoute 21:08:58.483 INFO Camel (camel-1) thread #3 - Delay [4bf92f3577b34da6a3ce929d0e0e4739,711f994843db5d13] route2 - in aFasterRoute 21:08:58.500 INFO Camel (camel-1) thread #4 - Delay [4bf92f3577b34da6a3ce929d0e0e4739,1219ea22da276463] route2 - still in aFasterRoute 21:08:58.519 INFO Camel (camel-1) thread #16 - NettyConsumerExecutorGroup [4bf92f3577b34da6a3ce929d0e0e4740,93029888ed44c3e3] netty - in netty route 21:08:58.520 INFO Camel (camel-1) thread #16 - NettyConsumerExecutorGroup [4bf92f3577b34da6a3ce929d0e0e4740,ee5d491873836fc4] route1 - in aSlowerRoute 21:08:58.719 INFO Camel (camel-1) thread #9 - Delay [4bf92f3577b34da6a3ce929d0e0e4740,ca1e85b164b97e35] route1 - still in aSlowerRoute 21:08:58.721 INFO Camel (camel-1) thread #9 - Delay [4bf92f3577b34da6a3ce929d0e0e4740,3a6a7afc4d2f88e7] route2 - in aFasterRoute 21:08:58.755 INFO Camel (camel-1) thread #10 - Delay [4bf92f3577b34da6a3ce929d0e0e4740,ca1e85b164b97e35] route2 - still in aFasterRoute 21:08:58.774 INFO Camel (camel-1) thread #20 - NettyConsumerExecutorGroup [8ab99ef0b2fbce66d11f747a1daf8f0c,f2baf5fab0ec1e7e] netty - in netty route 21:08:58.775 INFO Camel (camel-1) thread #20 - NettyConsumerExecutorGroup [8ab99ef0b2fbce66d11f747a1daf8f0c,e5e2fa3ad6919297] route1 - in aSlowerRoute 21:08:59.031 INFO Camel (camel-1) thread #5 - Delay [35e0dec31ec26df1204f91caa8f95091,3cae953a6f3821e4] route1 - still in aSlowerRoute 21:08:59.032 INFO Camel (camel-1) thread #5 - Delay [8ab99ef0b2fbce66d11f747a1daf8f0c,0e548f6037c7f4d8] route2 - in aFasterRoute 21:08:59.088 INFO Camel (camel-1) thread #6 - Delay [adb9fa707818304e40ec044a8a17bf93,037fa960a43b9ab2] route2 - still in aFasterRoute ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
