tdiesler commented on code in PR #16084:
URL: https://github.com/apache/camel/pull/16084#discussion_r1816030185
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/test/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/PodLogsTest.java:
##########
@@ -33,7 +33,8 @@ public void shouldHandlePodNotFound() throws Exception {
PodLogs command = createCommand();
command.name = "mickey-mouse";
command.maxWaitAttempts = 2; // total timeout of 4 seconds
- command.doCall();
+ int exit = command.doCall();
+ Assertions.assertEquals(1, exit);
Review Comment:
It is debatable, wether the `jbang camel kubernetes logs ...` command should
"fail" when the Pod is not there. User feedback (in print the output) is clear.
We might as well succeed the command and reserve failure to unexpected server
failures. Would that be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
