christophd commented on PR #15998: URL: https://github.com/apache/camel/pull/15998#issuecomment-2421636778
I think the root cause of all of this is that when using OpenShift as a `cluster-type` we switch from Kubernetes Quarkus extension to the OpenShift Quarkus extension and unfortunately these two seem to behave differently. The Quarkus Kubernetes extension properly merges the Kubernetes manifest coming from the Camel JBang plugin (in `src/main/kubernetes`) with its own generated Kubernetes manifest. The Quarkus OpenShift extension presumably is not doing the same merger so things like the INTEGRATION_LABEL may not get properly added to the final Kubernetes manifest. Switching from INTEGRATION_LABEL to KUBERNETES_NAME_LABEL as in this PR fixes it because KUBERNETES_NAME_LABEL is what the Quarkus extension uses. I am fine with the fix in this PR and I also think that is does not break existing behavior since the users coming from 4.8.0 will not face breaking changes because of this as it is an internal detail in the manifest. In general we need to analyze and find out why the Kubernetes manifest is not merged properly when using the Quarkus OpenShift extension. In 4.8.0 the focus was to support plain Kubernetes where all of this is working properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
