jamesnetherton commented on code in PR #6356:
URL: https://github.com/apache/camel-quarkus/pull/6356#discussion_r1719847776


##########
integration-tests/grpc/src/main/resources/application.properties:
##########
@@ -15,7 +15,7 @@
 ## limitations under the License.
 ## ---------------------------------------------------------------------------
 
-quarkus.native.resources.includes=certs/*.key,certs/*.pem,keys/*.json
+quarkus.native.resources.includes=target/certs/*.key,target/certs/*.pem,keys/*.json

Review Comment:
   Since certs are now read from the filesystem, I think this can be reduced to:
   
   ```suggestion
   quarkus.native.resources.includes=keys/*.json
   ```



##########
integration-tests/platform-http-proxy-ssl/src/main/resources/application.properties:
##########
@@ -16,4 +16,4 @@
 ## ---------------------------------------------------------------------------
 
 
-quarkus.native.resources.includes=certs/proxy-ssl-keystore.p12
\ No newline at end of file
+quarkus.native.resources.includes=target/certs/proxy-ssl-keystore.p12

Review Comment:
   I guess we can delete this file is nothing is reading certs from the 
classpath anymore.



##########
integration-tests/grpc/src/main/java/org/apache/camel/quarkus/component/grpc/it/GrpcRoute.java:
##########
@@ -45,7 +45,7 @@ public void configure() throws Exception {
 
         // Verifies that the serviceAccountResource can be loaded on startup
         from("direct:googleAuthenticationType")
-                
.toF("grpc://localhost:{{camel.grpc.test.async.server.port}}/%s?method=pingAsyncAsync&negotiationType=TLS&keyResource=certs/grpc.key&authenticationType=GOOGLE&serviceAccountResource=keys/app.json&KeyCertChainResource=certs/grpc.pem",
+                
.toF("grpc://localhost:{{camel.grpc.test.async.server.port}}/%s?method=pingAsyncAsync&negotiationType=TLS&keyResource=target/certs/grpc.key&authenticationType=GOOGLE&serviceAccountResource=keys/app.json&KeyCertChainResource=target/certs/grpc.pem",

Review Comment:
   ```suggestion
                   
.toF("grpc://localhost:{{camel.grpc.test.async.server.port}}/%s?method=pingAsyncAsync&negotiationType=TLS&keyResource=file:target/certs/grpc.key&authenticationType=GOOGLE&serviceAccountResource=keys/app.json&KeyCertChainResource=file:target/certs/grpc.pem",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to