ryan-highley commented on code in PR #15088: URL: https://github.com/apache/camel/pull/15088#discussion_r1717370165
########## components/camel-tahu/src/test/java/org/apache/camel/component/tahu/TahuHostConsumerTest.java: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.component.tahu; + +import org.apache.camel.CamelContext; +import org.apache.camel.test.infra.core.annotations.RouteFixture; +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.EnumSource; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@Disabled +public class TahuHostConsumerTest extends TahuTestSupport { + + static enum HostAppTestProfile { + SESSION_ESTABLISHMENT_TEST("host SessionEstablishmentTest", false), + SESSION_TERMINATION_TEST("host SessionTerminationTest TestHostApp", true), + // SEND_COMMAND_TEST("host SendCommandTest G2 E2 D2", false), + // EDGE_SESSION_TERMINATION_TEST("host EdgeSessionTerminationTest G2 E2 D2", false), + // MESSAGE_ORDERING_TEST("host MessageOrderingTest G2 E2 D2 5000", false), + ; + + private HostAppTestProfile(String testConfig, boolean disconnect) { + this.testConfig = testConfig; + this.disconnect = disconnect; + } + + final String testConfig; + final boolean disconnect; + } + + private static final Logger LOG = LoggerFactory.getLogger(TahuHostConsumerTest.class); + + @ParameterizedTest + @EnumSource + public void tckSessionTest(HostAppTestProfile profile) throws Exception { + + initiateTckTest(profile.testConfig); + + } + + @RouteFixture Review Comment: I really tried to pare down the test code. Every time I tried to pull completely away from `test-infra` the tests would stop working altogether. They're quite a bit cleaner with the last updates. Totally understand the API is more challenging but I didn't find it much harder than using Jupiter extensions. If you don't mind, could we please leave these as they are now? They're passing all the Sparkplug TCK tests I can reasonably automate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
