gansheer commented on PR #5757: URL: https://github.com/apache/camel-k/pull/5757#issuecomment-2288559907
> > > LGTM. Just a small question : wouldn't it be better to use `defaults.DefaultRuntimeVersion` instead of "3.8.1" in the tests ? > > > > > > Yeah, @lsergio it would be good if you can change in order to maintain consistency with the default settings (and other tests using the same). Thanks! > > Hi @squakez and @gansheer. When I do it, I get the following error while building: > > ``` > # github.com/apache/camel-k/v2/pkg/apis/camel/v1 > package github.com/apache/camel-k/v2/pkg/apis/camel/v1 > imports github.com/apache/camel-k/v2/pkg/util/defaults > imports github.com/apache/camel-k/v2/pkg/util/log > imports github.com/apache/camel-k/v2/pkg/apis/camel/v1: import cycle not allowed in test > ``` > > It is not really clear for me why this is happening. :( If someone can provide some hint, that would be great. I googled for the error and could not find anything helpful. For the test purpose, though, the runtime versions could be anything. I could have called them "runtime-1" and "runtime-2", for example. If these does not need a real runtime version, then I would go with fake ones like you suggest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
