kulagaIA commented on code in PR #14849:
URL: https://github.com/apache/camel/pull/14849#discussion_r1683276069
##########
core/camel-main/src/main/java/org/apache/camel/main/HttpServerConfigurationProperties.java:
##########
@@ -47,7 +47,10 @@ public class HttpServerConfigurationProperties implements
BootstrapCloseable {
private boolean uploadEnabled;
private String uploadSourceDir;
+ private HttpServerAuthenticationConfigurationProperties authentication;
Review Comment:
As far as I can understand, the problem is that with the current
implementation of closing BootstrapCloseable properties, we need to set links
to embedded properties to null so that they are eligible for gc. This is the
same as in
[org.apache.camel.main.MainConfigurationProperties](https://github.com/apache/camel/blob/main/core/camel-main/src/main/java/org/apache/camel/main/MainConfigurationProperties.java).
So to make those final, we need to see if we can close *Properties.java
objects in a different way, maybe this can be done in a separate issue/PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
