romain-pfund commented on code in PR #5650:
URL: https://github.com/apache/camel-k/pull/5650#discussion_r1642931097
##########
pkg/trait/ingress.go:
##########
@@ -126,6 +128,15 @@ func (t *ingressTrait) Apply(e *Environment) error {
},
}
+ if len(t.TLSHosts) > 0 || len(strings.TrimSpace(t.TLSSecretName)) > 0 {
+ ingress.Spec.TLS = []networkingv1.IngressTLS{
+ {
+ Hosts: t.TLSHosts,
+ SecretName: t.TLSSecretName,
+ },
+ }
+ }
Review Comment:
replace by
len(t.TLSHosts) > 0 && t.TLSSecretName != ""
+ 2 test added to cover both part of the if
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
