jamesnetherton commented on code in PR #6191:
URL: https://github.com/apache/camel-quarkus/pull/6191#discussion_r1642230723
##########
extensions/jasypt/deployment/src/test/java/org/apache/camel/quarkus/component/jasypt/JasyptPasswordNotProvidedTest.java:
##########
@@ -25,11 +28,27 @@
public class JasyptPasswordNotProvidedTest {
@RegisterExtension
static final QuarkusUnitTest CONFIG = new QuarkusUnitTest()
+ .overrideConfigKey("greeting.secret",
"ENC(GKJfy64eBDzxUuQCfArd6OjnAaW/oM9e)")
.setExpectedException(IllegalStateException.class)
- .setArchiveProducer(() -> ShrinkWrap.create(JavaArchive.class));
+ .setArchiveProducer(() ->
ShrinkWrap.create(JavaArchive.class).addClass(JasyptRoutes.class));
@Test
void passwordNotProvidedThrowsException() {
// Nothing to test as we just verify the application fails to start
}
+
+ public static final class JasyptRoutes extends RouteBuilder {
Review Comment:
Just curious why we add `RouteBuilder` classes to tests that do nothing
other that assert the application fails to start correctly?
Can we remove them from here and the other tests they got added to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
