Praval791 commented on PR #1314:
URL: https://github.com/apache/camel-karavan/pull/1314#issuecomment-2167086499

   > @Praval791 unfortunately I need to rollback your PR.
   > 
   > Numeric fields in DSL, Kamelets and Components may have explicit Numeric 
value or a placeholder, ex: `{{env:ENV_NAME}}`, `{{property}}`
   
   Hi @mgubaidullin 
   Thank you for the feedback. I understand that the numeric fields can also 
contain placeholders (If I got you correctly) and that my initial fix may not 
have accounted for this properly.
   
   To clarify the issue with a specific example, consider the following YAML 
configuration:
   
   ```yaml
   - route:
       id: route-d9b6
       nodePrefixId: route-7cc
       from:
         id: from-03ee
         uri: kamelet:aws-cloudtrail-source
         parameters:
           maxResults: 2
         steps:
           - to:
               id: to-ec0e
               uri: activemq
               parameters:
                 deliveryDelay: "1213"
   ```
   
   In this configuration, if you try to remove the maxResults field, you will 
notice that the backspace key does not allow clearing the value completely but 
the same thing is working in components. I only got this issue in Kamelets and 
DSL. 
   
   I will work on modifying my fix to ensure that both numeric values and 
placeholders are handled correctly. To help me better understand the 
requirements and make the necessary changes, could you please provide an 
example YAML configuration that includes placeholders? This would greatly 
assist me in ensuring that my fix covers all use cases.
   
   Thank you for your understanding and assistance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to