christophd commented on PR #5597: URL: https://github.com/apache/camel-k/pull/5597#issuecomment-2158869706
> about the knative trait, the same as above can apply as there (maybe) are some conflicting properties maybe ? i.e. what happen if you set a filter for a non broker resource? I have checked in the code and Camel K will create the trigger only when using the broker resource as a source. when referencing a Knative channel resource for instance Camel K will not create the trigger and it is assumed that the channel and the trigger are present already. So setting the trigger filter on the trait is only valid for broker type events. This is the result of us having a single Knative trait config for multiple Knative resources (broker, channel, service) as a source/sink. Again, this needs to be made clear in the documentation. I will take care of it (probably in a separate PR) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
