apupier opened a new pull request, #14409: URL: https://github.com/apache/camel/pull/14409
- Use specific image instead of jbang-action image which was initially designed for GitHub actions which is not actively maintained as jabg-action is no more the recommended way - Upgrade from JDK 11 to JDK 21 - Upgrade to JBang 0.116.0 - Added a line to warm up the dependencies which is drastically reduce the time to execute the docker image # Description The `version` call is now almost instant versus 2'30" for me with 4.6.0 as it was downloading a valid JDK (17) and downloading dependencies Remaining issues specific to this PR: * empty JBang version line is printed * the Dockerfile is repeating the Camel version at 2 places (not found how to use an env/variable in the entrypoint Important issues impacting previous versions too: * with `run` the file is not found (an be tried by following https://camel.apache.org/manual/camel-jbang.html#_container_image `docker run apache/camel-jbang:4.6.0 run example.yaml` ``` java.io.FileNotFoundException: demo.yaml (No such file or directory) at java.base/java.io.FileInputStream.open0(Native Method) at java.base/java.io.FileInputStream.open(FileInputStream.java:216) at java.base/java.io.FileInputStream.<init>(FileInputStream.java:157) at java.base/java.io.FileInputStream.<init>(FileInputStream.java:111) at org.apache.camel.dsl.jbang.core.commands.Run.knownFile(Run.java:1272) at org.apache.camel.dsl.jbang.core.commands.Run.run(Run.java:596) at org.apache.camel.dsl.jbang.core.commands.Run.doCall(Run.java:297) at org.apache.camel.dsl.jbang.core.commands.CamelCommand.call(CamelCommand.java:71) at org.apache.camel.dsl.jbang.core.commands.CamelCommand.call(CamelCommand.java:37) at picocli.CommandLine.executeUserObject(CommandLine.java:2041) at picocli.CommandLine.access$1500(CommandLine.java:148) at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461) at picocli.CommandLine$RunLast.handle(CommandLine.java:2453) at picocli.CommandLine$RunLast.handle(CommandLine.java:2415) at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273) at picocli.CommandLine$RunLast.execute(CommandLine.java:2417) at picocli.CommandLine.execute(CommandLine.java:2170) at org.apache.camel.dsl.jbang.core.commands.CamelJBangMain.run(CamelJBangMain.java:151) at org.apache.camel.dsl.jbang.core.commands.CamelJBangMain.run(CamelJBangMain.java:58) at main.CamelJBang.main(CamelJBang.java:36) ``` * with `init`, the file is created in the container and so not usable by the end user # Target - [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch) # Tracking - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). <!-- # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes. --> # Apache Camel coding standards and style - [ ] I checked that each commit in the pull request has a meaningful subject line and body. <!-- If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue. --> - [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes <!-- You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`. You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
