squakez commented on code in PR #5581:
URL: https://github.com/apache/camel-k/pull/5581#discussion_r1627023510
##########
e2e/advanced/maven_http_proxy_test.go:
##########
@@ -210,10 +210,15 @@ func TestMavenProxy(t *testing.T) {
g.Expect(err).To(Succeed())
g.Expect(proxies.Items).To(HaveLen(1))
+ ocp, err := openshift.IsOpenShift(TestClient(t))
+ require.NoError(t, err)
+
logs := Logs(t, ctx, ns, proxies.Items[0].Name,
corev1.PodLogOptions{})()
g.Expect(logs).NotTo(BeEmpty())
- g.Expect(logs).To(ContainSubstring("\"CONNECT
repo.maven.apache.org:443 HTTP/1.1\" 200"))
-
+ if !ocp {
+ // OpenShift has internal configuration (like oauth)
that overriddes the default repo connect URL
+ g.Expect(logs).To(ContainSubstring("\"CONNECT
repo.maven.apache.org:443 HTTP/1.1\" 200"))
Review Comment:
I'd avoid filling our code (also test code) with platform specific
conditions. I think we need to find a general way to make a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
