squakez commented on code in PR #5570:
URL: https://github.com/apache/camel-k/pull/5570#discussion_r1624050594
##########
e2e/support/test_support.go:
##########
@@ -2685,7 +2685,44 @@ func CreateOperatorRoleBinding(t *testing.T, ctx
context.Context, ns string) err
return nil
}
-func CreateKamelPod(t *testing.T, ctx context.Context, ns string, name string,
command ...string) error {
+func CreateKamelPodWithIntegrationSource(t *testing.T, ctx context.Context, ns
string, name string, integration v1.ValueSource, command ...string) error {
+ // This line prevents controller-runtime from complaining about
log.SetLogger never being called
+ logf.SetLogger(zap.New(zap.UseDevMode(true)))
Review Comment:
I think this one should be something generic instead of specific to some
given test.
##########
e2e/advanced/tekton_test.go:
##########
@@ -37,13 +41,50 @@ func TestTektonLikeBehavior(t *testing.T) {
t.Parallel()
WithNewTestNamespace(t, func(ctx context.Context, g *WithT, ns string) {
- g.Expect(CreateOperatorServiceAccount(t, ctx, ns)).To(Succeed())
- g.Expect(CreateOperatorRole(t, ctx, ns)).To(Succeed())
- g.Expect(CreateOperatorRoleBinding(t, ctx, ns)).To(Succeed())
-
- g.Eventually(OperatorPod(t, ctx, ns)).Should(BeNil())
- g.Expect(CreateKamelPod(t, ctx, ns, "tekton-task", "install",
"--skip-cluster-setup", "--olm=false", "--force")).To(Succeed())
+ operatorID := "camel-k-tekton-like"
+ g.Expect(CopyCamelCatalog(t, ctx, ns, operatorID)).To(Succeed())
Review Comment:
I think this is the case where we don't want to copy the catalog or the
existing kits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
