squakez commented on code in PR #5505:
URL: https://github.com/apache/camel-k/pull/5505#discussion_r1602790606
##########
e2e/advanced/tekton_test.go:
##########
@@ -42,7 +42,7 @@ func TestTektonLikeBehavior(t *testing.T) {
g.Expect(CreateOperatorRoleBinding(t, ctx, ns)).To(Succeed())
g.Eventually(OperatorPod(t, ctx, ns)).Should(BeNil())
- g.Expect(CreateKamelPod(t, ctx, ns, "tekton-task", "install",
"--skip-cluster-setup", "--force")).To(Succeed())
+ g.Expect(CreateKamelPod(t, ctx, ns, "tekton-task", "install",
"--skip-cluster-setup", "--olm=false", "--force")).To(Succeed())
Review Comment:
I think this test should be rewritten from scratch. Here what we're doing is
to create a Pod with the operator container and we're asking the Pod to execute
`kamel install ...` just to verify the executable works. I think that the
`kamel install` should not be used as for this purpose. Instead, we should
rewrite the test in order to validate something different, for instance `kamel
run` which is what we really expect to use in a Tekton task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
