lburgazzoli commented on code in PR #5488:
URL: https://github.com/apache/camel-k/pull/5488#discussion_r1595281935
##########
pkg/trait/jvm.go:
##########
@@ -81,10 +80,18 @@ func (t *jvmTrait) Configure(e *Environment) (bool,
*TraitCondition, error) {
if e.CamelCatalog == nil {
return false,
NewIntegrationConditionPlatformDisabledCatalogMissing(), nil
}
+
+ if t.Jar == "" && e.IntegrationKit != nil {
+ executableArtifact := e.IntegrationKit.GetExecutableArtifact()
+ if executableArtifact == nil {
+ return false, nil, fmt.Errorf("could not locate any
executable among Integration Kit %s artifacts", e.IntegrationKit.Name)
+ }
+ t.Jar = executableArtifact.Target
Review Comment:
unrelated, but it would be nice to have some design proposal for those
_sourceless_ integration because as today, I don't have a complete
understanding of how it is different from a normal integration (except from the
fact that the jvm trait should probably not be required in that case)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
