squakez commented on code in PR #5425: URL: https://github.com/apache/camel-k/pull/5425#discussion_r1580667845
########## pkg/apis/camel/v1/trait/dependencies.go: ########## @@ -20,7 +20,10 @@ package trait // The Dependencies trait is internally used to automatically add runtime dependencies based on the // integration that the user wants to run. // -// +camel-k:trait=dependencies. +// +camel-k:trait=dependencies +// +camel-k:internal +// +//lint:ignore SA1000 Ignore the requirement for comments to end in a period. Review Comment: Why ignoring the lint warning? IMO we should follow its guidelines and just add the dot at the end, as we were using to do before. Mind that by adding the `nolint` at that level we'd swallow any other lint warning related to this category. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
