jamesnetherton commented on code in PR #6042:
URL: https://github.com/apache/camel-quarkus/pull/6042#discussion_r1579360201


##########
integration-tests/lra/src/test/java/org/apache/camel/quarkus/component/lra/it/LraTestResource.java:
##########
@@ -58,7 +58,18 @@ public Map<String, String> start() {
                 lraPort = container.getMappedPort(LRA_PORT);
             }
 
+            // If the test runs with a remote docker, it needs to know the IP 
of the machine where the test app runs
+            if (System.getenv("DOCKER_HOST") != null) {
+                hostname = System.getProperty("lra.appNode.ip");

Review Comment:
   Ah I totally missed that, thanks.
   
   So, instead of having to manually pass along a system property, would it be 
enough to use `DockerClientFactory.instance().dockerHostIpAddress()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to