Re: [PR] fixes(#5424): Generate badges for deprecated traits [camel-k]

[via GitHub]

squakez commented on code in PR #5425:
URL: https://github.com/apache/camel-k/pull/5425#discussion_r1579311393


##########
pkg/apis/camel/v1/trait/dependencies.go:
##########
@@ -20,7 +20,8 @@ package trait
 // The Dependencies trait is internally used to automatically add runtime 
dependencies based on the
 // integration that the user wants to run.
 //
-// +camel-k:trait=dependencies.
+// +camel-k:trait=dependencies
+// +camel-k:deprecated=2.4.0

Review Comment:
   Why is the dependencies deprecated!?



##########
docs/modules/traits/pages/tracing.adoc:
##########
@@ -1,5 +1,7 @@
 = Tracing Trait
 
+// Start of autogenerated code - DO NOT EDIT! (badges)
+// End of autogenerated code - DO NOT EDIT! (badges)
 // Start of autogenerated code - DO NOT EDIT! (description)
 WARNING: The Tracing trait has been **deprecated** in favor of the 
xref:traits:telemetry.adoc[Telemetry] trait.

Review Comment:
   Probably you want to add this trait as well



##########
pkg/apis/camel/v1/trait/registry.go:
##########
@@ -17,12 +17,11 @@ limitations under the License.
 
 package trait
 
-// WARNING: The Registry trait is **deprecated** and will removed in future 
release versions.
-//
 // The Registry trait sets up Maven to use the Image registry
 // as a Maven repository.
 //
-// +camel-k:trait=registry.
+// +camel-k:trait=registry
+// +camel-k:deprecated=2.3.0

Review Comment:
   It was deprecated already in version 2.2.0 IIRC



##########
docs/modules/traits/pages/registry.adoc:
##########
@@ -1,8 +1,9 @@
 = Registry Trait
 
+// Start of autogenerated code - DO NOT EDIT! (badges)
+image:https://img.shields.io/badge/2.3.0?label=Deprecated&labelColor=%23C40C0C&color=gray[Deprecated
 Badge]

Review Comment:
   Are you sure this is the correct format? in the rich diff I cannot see the 
image, but the text instead. We are using this badge for coverage as well, for 
example: `image:https://img.shields.io/badge/Coverage-38.0%25-yellow.svg["Go 
coverage"]`



##########
docs/modules/ROOT/partials/apis/camel-k-crds.adoc:
##########
@@ -8240,8 +8240,6 @@ Deprecated: for backward compatibility.
 * <<#_camel_apache_org_v1_IntegrationKitTraits, IntegrationKitTraits>>
 * <<#_camel_apache_org_v1_Traits, Traits>>
 
-WARNING: The Registry trait is **deprecated** and will removed in future 
release versions.

Review Comment:
   Probably you need to amend the crds doc generation as well to include the 
deprecation notice in the API description



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org