squakez commented on code in PR #5415: URL: https://github.com/apache/camel-k/pull/5415#discussion_r1577831238
########## e2e/support/test_support.go: ########## @@ -128,9 +128,9 @@ const ExpectedOSClusterRoles = 1 var TestDefaultNamespace = "default" -var TestTimeoutShort = 1 * time.Minute -var TestTimeoutMedium = 5 * time.Minute -var TestTimeoutLong = 15 * time.Minute +var TestTimeoutShort = 5 * time.Minute Review Comment: That's exactly the problem. In case of an unstable change we may introduce, the time to complete a test would be at least duplicated, having to wait for a feedback too much time. Imho, the goal should be to have faster timeouts. If some test is not stable, then, I don't think the culprit is the timeout. And if it's the timeout, likely it's in the specific flaky test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
