lburgazzoli commented on PR #5399: URL: https://github.com/apache/camel-k/pull/5399#issuecomment-2074429132
> I understand that you're proposing to force the possibility to run a container image previously built by the operator only with the associated IntegrationKit (which must be copied from its source), is it correct? This feature already exists (ie, `kamel run --kit`) and this PR should not have affected it at all. > It is a little bit broader than this because as today you can instruct camel-k to run an integration against a pre-existing container image in two ways: 1. by creating an external `IntegrationKit` with the given image and reference it in the `Integration` spec 2. by setting the image on the `container` trait (which then generates an external `IntegrationKit` behind the scenes, then point 1) 3. by copying the `IntegrationKit` and reference it in the `Integration` spec Now I think is where things gets a little bit confusing as yes you can use `kamel run --kit`, but such kit may or may not be built using a camel-k compatible image so you could potentially have to set the image format i.e. with `kamel run --kit ... --container.image-format=...`, even if you are referencing a kit which, by definition, is expected to describe an image. This is why I think, the information about the image format is more a Kit specific trait (maybe it can be part of the spec, along with the image property). > the main reason of this PR was to address certain failing tests that were assuming that we can run an Integration with a `container.image` coming off from a previous external IntegrationKit. I think @valdar did some work in https://github.com/apache/camel-k/pull/5119 to fix this issue , may be worth having a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
