tdiesler commented on PR #5317: URL: https://github.com/apache/camel-k/pull/5317#issuecomment-2042334426
There are (currently) three usages of apis.AddToScheme * when there is an error on operator startup * with some "fake" client while testing * whenever a client with config is needed I ignored the first two and believe it is correct to sync in NewClientWithConfig which IMHO is close enough to `runtime.SchemeBuilder.AddToScheme` where the problem actually is. The idea is, that it is probably ok to sync the creation of a non-trivial k8s client, which apparently does work sensitive to concurrency issues. At the same time, I assume that creation of such a client is fast enough that it does not need to happen in parallel on the same Go runtime. Sure, lets try to remove that other mutex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
