lburgazzoli commented on code in PR #1185:
URL: https://github.com/apache/camel-k-runtime/pull/1185#discussion_r1530093304
##########
support/camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java:
##########
@@ -464,7 +465,11 @@ private void addCapabilities(RuntimeSpec.Builder
runtimeSpec, CamelCatalogSpec.B
artifacts.clear();
artifacts.add(Artifact.from("org.apache.camel.quarkus",
"camel-quarkus-microprofile-health"));
- addCapabilityAndDependecies(runtimeSpec, catalogSpec, "health",
artifacts, false);
+ List<Property> properties = new ArrayList<>();
+ properties.add(Property.from("defaultLivenessProbePath",
"/q/health/live"));
+ properties.add(Property.from("defaultReadinessProbePath",
"/q/health/ready"));
+ properties.add(Property.from("defaultStartupProbePath",
"/q/health/started"));
Review Comment:
the main issue is about cognitive load as one has to take into account that
for the health, they have a different meaning than for other traits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
