tdiesler commented on code in PR #5246:
URL: https://github.com/apache/camel-k/pull/5246#discussion_r1522987162
##########
pkg/util/defaults/defaults.go:
##########
@@ -44,5 +44,10 @@ const (
installDefaultKamelets = true
)
+// Maps base image variants to their respective digests
+var baseImageVariantMapping = map[string]string{
Review Comment:
What you see here is the result of Makefile code generation. Perhaps this
file should be in .gitignore
In Makefile we get the digest like this ...
```
ARM64_DIGEST := $(shell docker manifest inspect eclipse-temurin:17 | jq -r
'.manifests[] | select(.platform.architecture == "arm64") | .digest')
```
True, this approach fixes the base image digest at build time instead of
dynamically loading the correct variant at maven build time - I could not find
the source for that. Perhaps we can still get this into the code base for now
and have a separate issues for (OLM, Helm, Kustomize)
Alternatively, we could do the above lookup (every time) when the base image
is actually needed, which I assume would then work for all install methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
