claudio4j commented on code in PR #5245:
URL: https://github.com/apache/camel-k/pull/5245#discussion_r1522896048
##########
pkg/trait/error_handler.go:
##########
@@ -107,3 +120,17 @@ func (t *errorHandlerTrait)
addGlobalErrorHandlerAsSource(e *Environment) error
return nil
}
+
+// shouldHandleNoErrorHandler determines the runtime version and checks on
noErrorHandler that is configured for this version.
+func shouldHandleNoErrorHandler(it *v1.Integration) bool {
+ if it.Status.RuntimeVersion != "" {
+ runtimeVersion, _ :=
strings.CutSuffix(it.Status.RuntimeVersion, "-SNAPSHOT")
+ if versionNumber, err :=
strconv.Atoi(strings.ReplaceAll(runtimeVersion, ".", "")); err == nil {
Review Comment:
The downstream version is something like "3.2.0.redhat-00014", I didn't
check this function, but I remember having issues parsing the downstream
version, so just a reminder to take this into account. We can also add this
specific to the downstream fork if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
